Attachment 57240 Details for Bug 17559 – [SIGNED-OFF] Bug 17559: Fixed HTML element ID of B_streetnumber

[patch] [SIGNED-OFF] Bug 17559: Fixed HTML element ID of B_streetnumber

SIGNED-OFF-Bug-17559-Fixed-HTML-element-ID-of-Bstr.patch (text/plain), 2.62 KB, created by Josef Moravec on 2016-11-07 07:18:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2016-11-07 07:18:08 UTC

Size: 2.62 KB

patch

obsolete

>From 6256175db09f7d638e768ca584059ccffabb6748 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Radek=20=C5=A0iman?= <rbit@rbit.cz>
>Date: Thu, 3 Nov 2016 14:45:43 +0100
>Subject: [PATCH] [SIGNED-OFF] Bug 17559: Fixed HTML element ID of
> B_streetnumber
>
>There is a duplicate ID in HTML code, because of this:
><input type="text" id="B_address" name="B_streetnumber" size="5"
>value="" />
><input type="text" id="B_address" name="B_address" size="40" value="" />
>
>Test plan:
>1) Edit a patron and look into its HTML code
>2) Find input: name="B_streetnumber"
>3) Its ID is B_address - a duplicate within the code in fact
>4) Apply the patch
>5) Repeat steps 1 and 2
>6) The ID is unique now: B_streetnumber
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> .../intranet-tmpl/prog/en/includes/member-alt-address-style-de.inc      | 2 +-
> .../intranet-tmpl/prog/en/includes/member-alt-address-style-us.inc      | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-de.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-de.inc
>index 43385f2..dba4222 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-de.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-de.inc
>@@ -43,7 +43,7 @@
>                     <label for="B_streetnumber">
>                 [% END %]
>                 Street Number: </label>
>-                    <input type="text" id="B_address" name="B_streetnumber" size="5" value="[% B_streetnumber %]" />
>+                    <input type="text" id="B_streetnumber" name="B_streetnumber" size="5" value="[% B_streetnumber %]" />
>                 [% IF ( mandatoryB_streetnumber ) %]<span class="required">Required</span>[% END %]
>             </li>
>         [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-us.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-us.inc
>index 7c4adbd..9ae71c1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-us.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-us.inc
>@@ -8,7 +8,7 @@
>                     <label for="B_streetnumber">
>                 [% END %]
>                 Street Number: </label>
>-                <input type="text" id="B_address" name="B_streetnumber" size="5" value="[% B_streetnumber %]" />
>+                <input type="text" id="B_streetnumber" name="B_streetnumber" size="5" value="[% B_streetnumber %]" />
>                [% IF ( mandatoryB_streetnumber ) %]<span class="required">Required</span>[% END %]
>             </li>
>         [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17559: 57225 | 57240 | 57638