Attachment 57285 Details for Bug 17431 – [SIGNED-OFF] Bug 17431: Fix another fail in t/db_dependent/api/v1/holds.t

[patch] [SIGNED-OFF] Bug 17431: Fix another fail in t/db_dependent/api/v1/holds.t

SIGNED-OFF-Bug-17431-Fix-another-fail-in-tdbdepend.patch (text/plain), 1.66 KB, created by Josef Moravec on 2016-11-07 21:00:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2016-11-07 21:00:43 UTC

Size: 1.66 KB

patch

obsolete

>From 83263641d2d6263e857ba7a7b006d05b63f6d78e Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@jns.fi>
>Date: Mon, 7 Nov 2016 15:28:42 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 17431: Fix another fail in
> t/db_dependent/api/v1/holds.t
>
>perl t/db_dependent/api/v1/holds.t fails with 500
>
>ok 2 - Test endpoints without permission
>    # Subtest: Test endpoints without permission, but accessing own object
>    1..15
>    ok 1 - POST /api/v1/holds
>    not ok 2 - 201 Created
>    #   Failed test '201 Created'
>    #   at t/db_dependent/api/v1/holds.t line 189.
>    #          got: '500'
>    #     expected: '201'
>    not ok 3 - has value for JSON Pointer "/reserve_id"
>    #   Failed test 'has value for JSON Pointer "/reserve_id"'
>    #   at t/db_dependent/api/v1/holds.t line 189.
>    ok 4 - GET /api/v1/holds?borrowernumber=659207
>    ok 5 - 200 OK
>    not ok 6 - exact match for JSON Pointer "/0/borrowernumber"
>    #   Failed test 'exact match for JSON Pointer "/0/borrowernumber"'
>    #   at t/db_dependent/api/v1/holds.t line 199.
>    #          got: undef
>    #     expected: '659207'
>
>To test:
>1. Run t/db_dependent/api/v1/holds.t
>2. Observe above failure
>3. Apply patch
>4. Observe test pass
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> t/db_dependent/api/v1/holds.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/api/v1/holds.t b/t/db_dependent/api/v1/holds.t
>index 8395f52..7841d4a 100644
>--- a/t/db_dependent/api/v1/holds.t
>+++ b/t/db_dependent/api/v1/holds.t
>@@ -25,8 +25,8 @@ use DateTime;
> 
> use C4::Context;
> use C4::Biblio;
>-use C4::Items;
> use C4::Reserves;
>+use C4::Items;
> 
> use Koha::Database;
> use Koha::Patron;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17431: 56252 | 56288 | 56655 | 56656 | 56657 | 56658 | 57258 | 57282 | 57283 | 57284 | 57285 | 57584 | 57585 | 57600 | 57601 | 57602 | 57603