Bugzilla – Attachment 57365 Details for
Bug 17584
Add the Koha::Patron->checkouts method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 17584: Add the Koha::Patron->get_issues method
SIGNED-OFF-Bug-17584-Add-the-KohaPatron-getissues-.patch (text/plain), 3.41 KB, created by
Josef Moravec
on 2016-11-09 10:10:31 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 17584: Add the Koha::Patron->get_issues method
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2016-11-09 10:10:31 UTC
Size:
3.41 KB
patch
obsolete
>From b271861305e63914d27e5a482e15caa1d94e21d4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 8 Nov 2016 12:52:52 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 17584: Add the Koha::Patron->get_issues > method > >Test plan: > prove t/db_dependent/Koha/Patrons.t >should return green > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > Koha/Patron.pm | 16 +++++++++++++--- > t/db_dependent/Koha/Patrons.t | 15 ++++++++++++--- > 2 files changed, 25 insertions(+), 6 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index 27a7af8..c0d3515 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -449,6 +449,18 @@ sub add_enrolment_fee_if_needed { > return $enrolment_fee || 0; > } > >+=head3 get_issues >+ >+my $issues = $patron->get_issues >+ >+=cut >+ >+sub get_issues { >+ my ($self) = @_; >+ my $issues = $self->_result->issues; >+ return Koha::Issues->_new_from_dbic( $issues ); >+} >+ > =head3 get_overdues > > my $overdue_items = $patron->get_overdues >@@ -460,16 +472,14 @@ Return the overdued items > sub get_overdues { > my ($self) = @_; > my $dtf = Koha::Database->new->schema->storage->datetime_parser; >- my $issues = Koha::Issues->search( >+ return $self->get_issues->search( > { >- 'me.borrowernumber' => $self->borrowernumber, > 'me.date_due' => { '<' => $dtf->format_datetime(dt_from_string) }, > }, > { > prefetch => { item => { biblio => 'biblioitems' } }, > } > ); >- return $issues; > } > > =head3 type >diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t >index d15e351..40f74b1 100644 >--- a/t/db_dependent/Koha/Patrons.t >+++ b/t/db_dependent/Koha/Patrons.t >@@ -516,8 +516,8 @@ subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub { > Koha::Patrons->find( $userenv_patron->{borrowernumber})->delete; > }; > >-subtest 'get_overdues' => sub { >- plan tests => 4; >+subtest 'get_issues + get_overdues' => sub { >+ plan tests => 8; > > my $library = $builder->build( { source => 'Branch' } ); > my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' ); >@@ -559,8 +559,13 @@ subtest 'get_overdues' => sub { > } > ); > >+ $patron = Koha::Patrons->find( $patron->{borrowernumber} ); >+ my $issues = $patron->get_issues; >+ is( $issues->count, 0, 'get_issues should not return any issues for that patron' ); >+ is( ref($issues), 'Koha::Issues', 'get_issues should return a Koha::Issues object' ); >+ > # Not sure how this is useful, but AddIssue pass this variable to different other subroutines >- $patron = GetMember( borrowernumber => $patron->{borrowernumber} ); >+ $patron = GetMember( borrowernumber => $patron->borrowernumber ); > > my $module = new Test::MockModule('C4::Context'); > $module->mock( 'userenv', sub { { branch => $library->{branchcode} } } ); >@@ -570,6 +575,10 @@ subtest 'get_overdues' => sub { > AddIssue( $patron, $item_3->{barcode} ); > > $patron = Koha::Patrons->find( $patron->{borrowernumber} ); >+ $issues = $patron->get_issues; >+ is( $issues->count, 3, 'get_issues should return 3 issues for that patron' ); >+ is( ref($issues), 'Koha::Issues', 'get_issues should return a Koha::Issues object' ); >+ > my $overdues = $patron->get_overdues; > is( $overdues->count, 2, 'Patron should have 2 overdues'); > is( ref($overdues), 'Koha::Issues', 'Koha::Patron->get_overdues should return Koha::Issues' ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17584
:
57331
|
57365
|
57971
|
58295
|
58419
|
58420