Bugzilla – Attachment 57602 Details for
Bug 17431
Fix failing test t/db_dependent/api/v1/holds.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17431: Create the object we need instead of assuming something exists
Bug-17431-Create-the-object-we-need-instead-of-ass.patch (text/plain), 1.23 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-11-17 14:29:12 UTC
(
hide
)
Description:
Bug 17431: Create the object we need instead of assuming something exists
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-11-17 14:29:12 UTC
Size:
1.23 KB
patch
obsolete
>From 4e1d96e2a03b04d4ed513612162ec11ea5fa2341 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 19 Oct 2016 14:14:41 +0100 >Subject: [PATCH] Bug 17431: Create the object we need instead of assuming > something exists > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/api/v1/holds.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/api/v1/holds.t b/t/db_dependent/api/v1/holds.t >index 8e79d19..8395f52 100644 >--- a/t/db_dependent/api/v1/holds.t >+++ b/t/db_dependent/api/v1/holds.t >@@ -41,8 +41,8 @@ $ENV{REMOTE_ADDR} = '127.0.0.1'; > my $t = Test::Mojo->new('Koha::REST::V1'); > my $tx; > >-my $categorycode = Koha::Database->new()->schema()->resultset('Category')->first()->categorycode(); >-my $branchcode = Koha::Database->new()->schema()->resultset('Branch')->first()->branchcode(); >+my $categorycode = $builder->build({ source => 'Category' })->{categorycode}; >+my $branchcode = $builder->build({ source => 'Branch' })->{branchcode}; > > # User without any permissions > my $nopermission = $builder->build({ >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17431
:
56252
|
56288
|
56655
|
56656
|
56657
|
56658
|
57258
|
57282
|
57283
|
57284
|
57285
|
57584
|
57585
|
57600
|
57601
| 57602 |
57603