Attachment 57611 Details for Bug 17601 – Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610

[patch] Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610

Bug-17601---Regression-Incomplete-CSS-update-intro.patch (text/plain), 4.37 KB, created by Katrin Fischer on 2016-11-18 07:05:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-11-18 07:05:49 UTC

Size: 4.37 KB

patch

obsolete

>From 8065708eba016d4a937dbed8efcc205749ad2d06 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 10 Nov 2016 10:47:25 +0000
>Subject: [PATCH] Bug 17601 - Regression: Incomplete CSS update introduced by
> Bug 14610
>
>Bug 14610 revised staff-global.css so that the "holdcount" class was
>renamed "number_box." That's good. It's good to have something more
>generic since the class is used in multiple places.
>
>The problem is that there are still several instances of the "holdcount"
>class in the templates which should have been updated at the same time
>to say "number_box." Those instances are now unstyled.
>
>Test Plan:
>1) Apply this patch
>2) Check that the holds count on catalogue/detail.pl is styled
>3) Check that the patron modifications count on members/member.pl is styled
>4) Check that the pending comments count on tools/tools-home.pl is styled
>5) Check that the pending tags count on tools/tools-home.pl is styled
>
>Signed-off-by: Chris Kirby <christopherlawrencekirby@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 2b6583b..c0151e9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -583,7 +583,7 @@ function verify_images() {
> [% END %]
> </ul></li>
> [% END %]
>- [% IF ( holdcount ) %]<li>Holds: <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]">[% holdcount %]</a></li>[% ELSE %][% END %]
>+ [% IF ( holdcount ) %]<li>Holds: <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]">[% holdcount %]</a></li>[% ELSE %][% END %]
> </ul>
> 		[% END %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>index 09e9f9d..6938f57 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>@@ -346,7 +346,7 @@ function filterByFirstLetterSurname(letter) {
> [% IF ( CAN_user_borrowers && pending_borrower_modifications ) %]
> <div class="pending-info" id="patron_updates_pending">
> <a href="/cgi-bin/koha/members/members-update.pl">Patrons requesting modifications</a>:
>- <a href="/cgi-bin/koha/members/members-update.pl">[% pending_borrower_modifications %]</a>
>+ <a href="/cgi-bin/koha/members/members-update.pl">[% pending_borrower_modifications %]</a>
> </div>
> [% END %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>index 09bc4b6..3220aad 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>@@ -21,7 +21,7 @@
> [% END %]
> 
> [% IF ( CAN_user_tools_moderate_comments ) %]
>- <dt><a href="/cgi-bin/koha/reviews/reviewswaiting.pl">Comments</a> [% IF ( pendingcomments ) %]<a href="/cgi-bin/koha/reviews/reviewswaiting.pl">[% pendingcomments %]</a>[% END %]</dt>
>+ <dt><a href="/cgi-bin/koha/reviews/reviewswaiting.pl">Comments</a> [% IF ( pendingcomments ) %]<a href="/cgi-bin/koha/reviews/reviewswaiting.pl">[% pendingcomments %]</a>[% END %]</dt>
> 	<dd>Moderate patron comments. </dd>
> [% END %]
> 
>@@ -56,7 +56,7 @@
> [% END %]
> 
> [% IF ( CAN_user_tools_moderate_tags ) %]
>- <dt><a href="/cgi-bin/koha/tags/review.pl">Tags</a> [% IF ( pendingtags ) %]<a href="/cgi-bin/koha/tags/review.pl">[% pendingtags %]</a>[% END %]</dt>
>+ <dt><a href="/cgi-bin/koha/tags/review.pl">Tags</a> [% IF ( pendingtags ) %]<a href="/cgi-bin/koha/tags/review.pl">[% pendingtags %]</a>[% END %]</dt>
> 	<dd>Moderate patron tags</dd>
> [% END %]
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17601: 57422 | 57466 | 57611 | 57612