Bugzilla – Attachment 57657 Details for
Bug 17642
Authorised values code is broken because of the refactoring
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17642: [QA Follow-up] Issues_stats.pl is not plack safe
Bug-17642-QA-Follow-up-Issuesstatspl-is-not-plack-.patch (text/plain), 2.07 KB, created by
Martin Renvoize (ashimema)
on 2016-11-18 15:51:36 UTC
(
hide
)
Description:
Bug 17642: [QA Follow-up] Issues_stats.pl is not plack safe
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2016-11-18 15:51:36 UTC
Size:
2.07 KB
patch
obsolete
>From 9bb7b3dcc53806570aad09d33a922f7e5d7eba77 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 18 Nov 2016 08:37:07 +0100 >Subject: [PATCH] Bug 17642: [QA Follow-up] Issues_stats.pl is not plack safe > >Resolve: >Variable "$ccodes" is not available at reports/issues_stats.pl line 358. >Variable "$locations" is not available at reports/issues_stats.pl line 359. >Variable "$ccodes" is not available at reports/issues_stats.pl line 358. >Variable "$locations" is not available at reports/issues_stats.pl line 359. > >Test plan: >Run the script. Choose Collection or Shelving Location. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > reports/issues_stats.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl >index 63501be..4241393 100755 >--- a/reports/issues_stats.pl >+++ b/reports/issues_stats.pl >@@ -90,8 +90,8 @@ $template->param(do_it => $do_it, > our $itemtypes = GetItemTypes(); > our @patron_categories = Koha::Patron::Categories->search_limited({}, {order_by => ['description']}); > >-my $locations = { map { ( $_->{authorised_value} => $_->{lib} ) } Koha::AuthorisedValues->get_descriptions_by_koha_field( { frameworkcode => '', kohafield => 'items.location' }, { order_by => ['description'] } ) }; >-my $ccodes = { map { ( $_->{authorised_value} => $_->{lib} ) } Koha::AuthorisedValues->get_descriptions_by_koha_field( { frameworkcode => '', kohafield => 'items.ccode' }, { order_by => ['description'] } ) }; >+our $locations = { map { ( $_->{authorised_value} => $_->{lib} ) } Koha::AuthorisedValues->get_descriptions_by_koha_field( { frameworkcode => '', kohafield => 'items.location' }, { order_by => ['description'] } ) }; >+our $ccodes = { map { ( $_->{authorised_value} => $_->{lib} ) } Koha::AuthorisedValues->get_descriptions_by_koha_field( { frameworkcode => '', kohafield => 'items.ccode' }, { order_by => ['description'] } ) }; > > our $Bsort1 = GetAuthorisedValues("Bsort1"); > our $Bsort2 = GetAuthorisedValues("Bsort2"); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17642
:
57533
|
57569
|
57570
|
57571
|
57572
|
57573
|
57574
|
57595
|
57616
|
57628
|
57629
|
57630
|
57631
|
57632
|
57633
|
57634
|
57635
|
57650
|
57651
|
57652
|
57653
|
57654
|
57655
|
57656
| 57657