Bugzilla – Attachment 57814 Details for
Bug 17696
Two missing periods in opac-suggestions.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Attachment to Bug 17696 - Two missing periods in opac-suggestions.tt
Bug-17696-missing-periods-in-opac-suggestionstt.patch (text/plain), 3.40 KB, created by
Alex Buckley
on 2016-11-30 00:14:08 UTC
(
hide
)
Description:
Attachment to Bug 17696 - Two missing periods in opac-suggestions.tt
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2016-11-30 00:14:08 UTC
Size:
3.40 KB
patch
obsolete
>From b948a9b4257474c6749bb2e82e69bd64924c2865 Mon Sep 17 00:00:00 2001 >From: phette23 <phette23@gmail.com> >Date: Tue, 29 Nov 2016 12:16:23 -0800 >Subject: [PATCH] Bug 17696: missing periods in opac-suggestions.tt > >Problem: > >- two missing trailing periods in template > >Test plan: > >- configure MaxOpenSuggestions with a low limit (e.g. 1) >- visit opac-suggestions.pl?op=add, login if necessary >- note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading >- continue to submit suggestions until you've reached the MaxOpenSuggestions limit >- observe the missing period in the "TooManySuggestionsText" paragraph >- apply patch >- revisit opac-suggestions.pl?op=add >- note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading >- note that the period is also present at the end of the "TooManySuggestionsText" paragraph > >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> > > HEAD detached from origin/master > Changes to be committed: > modified: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index 2645905..fa9da1f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -35,7 +35,7 @@ > [% ELSE %] > <h1>Enter a new purchase suggestion</h1> > >- <p>Please fill out this form to make a purchase suggestion. You will receive an email when the library processes your suggestion</p> >+ <p>Please fill out this form to make a purchase suggestion. You will receive an email when the library processes your suggestion.</p> > <p>Only certain fields (marked in red) are required, but the more information you enter the easier it will be for the librarians to find the title you're requesting. The "Notes" field can be used to provide any additional information.</p> > > <form action="/cgi-bin/koha/opac-suggestions.pl" method="post" id="add_suggestion_form"> >@@ -256,7 +256,7 @@ > [% END %] > [% IF ( loggedinusername || ( Koha.Preference( 'AnonSuggestions' ) == 1 ) ) %] > [% IF ( Koha.Preference('MaxOpenSuggestions') != '' && patrons_pending_suggestions_count >= Koha.Preference('MaxOpenSuggestions') ) %] >- <p class="TooManySuggestionsText">You have reached your limit of suggestions you can place at this time.</br>Once the library has processed those suggestions you will be able to place more</p> >+ <p class="TooManySuggestionsText">You have reached your limit of suggestions you can place at this time.</br>Once the library has processed those suggestions you will be able to place more.</p> > [% ELSE %] > <p><a class="new" href="/cgi-bin/koha/opac-suggestions.pl?op=add">New purchase suggestion</a></p> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17696
:
57809
|
57812
|
57814
|
57831