Bugzilla – Attachment 57883 Details for
Bug 17671
Remove unused variables in Reserves.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17671: Remove unused variables in C4::Reserves
Bug-17671-Remove-unused-variables-in-C4Reserves.patch (text/plain), 2.44 KB, created by
Marcel de Rooy
on 2016-12-02 07:49:09 UTC
(
hide
)
Description:
Bug 17671: Remove unused variables in C4::Reserves
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-12-02 07:49:09 UTC
Size:
2.44 KB
patch
obsolete
>From 1a55884d6f16b07989fb82a0a5576fc1a3338410 Mon Sep 17 00:00:00 2001 >From: =?utf-8?q?Petter=20Goks=C3=B8yr=20=C3=85sen?= > <boutrosboutrosboutros@gmail.com> >Date: Wed, 23 Nov 2016 11:12:24 +0100 >Subject: [PATCH] Bug 17671: Remove unused variables in C4::Reserves >Content-Type: text/plain; charset=utf-8 > >I was reading through Reserves.pm trying to figure out a bug - found some >unused variables instead. > >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Reserves.pm | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 83903e8..9ef33ad 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -175,8 +175,6 @@ sub AddReserve { > $title, $checkitem, $found, $itemtype > ) = @_; > >- my $dbh = C4::Context->dbh; >- > $resdate = output_pref( { str => dt_from_string( $resdate ), dateonly => 1, dateformat => 'iso' }) > or output_pref({ dt => dt_from_string, dateonly => 1, dateformat => 'iso' }); > >@@ -1182,7 +1180,6 @@ sub ModReserve { > return unless ( $reserve_id || ( $borrowernumber && ( $biblionumber || $itemnumber ) ) ); > $reserve_id = GetReserveId({ biblionumber => $biblionumber, borrowernumber => $borrowernumber, itemnumber => $itemnumber }) unless ( $reserve_id ); > >- my $dbh = C4::Context->dbh; > if ( $rank eq "del" ) { > CancelReserve({ reserve_id => $reserve_id }); > } >@@ -1232,8 +1229,6 @@ sub ModReserveFill { > my ($res) = @_; > my $reserve_id = $res->{'reserve_id'}; > >- my $dbh = C4::Context->dbh; >- > my $hold = Koha::Holds->find($reserve_id); > > # get the priority on this record.... >@@ -1247,7 +1242,7 @@ sub ModReserveFill { > } > ); > >- my $old_hold = Koha::Old::Hold->new( $hold->unblessed() )->store(); >+ Koha::Old::Hold->new( $hold->unblessed() )->store(); > > $hold->delete(); > >@@ -1596,8 +1591,6 @@ Input: $where is 'up', 'down', 'top' or 'bottom'. Biblionumber, Date reserve was > sub AlterPriority { > my ( $where, $reserve_id ) = @_; > >- my $dbh = C4::Context->dbh; >- > my $reserve = GetReserve( $reserve_id ); > > if ( $reserve->{cancellationdate} ) { >@@ -2176,7 +2169,6 @@ sub MoveReserve { > return unless $res; > > my $biblionumber = $res->{biblionumber}; >- my $biblioitemnumber = $res->{biblioitemnumber}; > > if ($res->{borrowernumber} == $borrowernumber) { > ModReserveFill($res); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17671
:
57726
|
57850
| 57883