Bugzilla – Attachment 57928 Details for
Bug 17713
Members.t is failing randomly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17713: Fix Members.t tests
Bug-17713-Fix-Memberst-tests.patch (text/plain), 1.79 KB, created by
Jonathan Druart
on 2016-12-02 15:12:24 UTC
(
hide
)
Description:
Bug 17713: Fix Members.t tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-12-02 15:12:24 UTC
Size:
1.79 KB
patch
obsolete
>From 479fef465ce45067a8612fe9fd739e72b4c3626d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 2 Dec 2016 15:10:51 +0000 >Subject: [PATCH] Bug 17713: Fix Members.t tests > >If the category_type is 'S', GetBorrowersToExpunge won't return the >patron. > >Test plan: > t/db_dependent/Members.t >should always return green >--- > t/db_dependent/Members.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t >index 963d790..998c64f 100755 >--- a/t/db_dependent/Members.t >+++ b/t/db_dependent/Members.t >@@ -349,9 +349,9 @@ is( scalar(@$patstodel),2,'Borrowers without issues deleted by last issue date') > > # Test GetBorrowersToExpunge and TrackLastPatronActivity > $dbh->do(q|UPDATE borrowers SET lastseen=NULL|); >-$builder->build({ source => 'Borrower', value => { lastseen => '2016-01-01 01:01:01', guarantorid => undef } } ); >-$builder->build({ source => 'Borrower', value => { lastseen => '2016-02-02 02:02:02', guarantorid => undef } } ); >-$builder->build({ source => 'Borrower', value => { lastseen => '2016-03-03 03:03:03', guarantorid => undef } } ); >+$builder->build({ source => 'Borrower', value => { lastseen => '2016-01-01 01:01:01', categorycode => 'CIVILIAN', guarantorid => undef } } ); >+$builder->build({ source => 'Borrower', value => { lastseen => '2016-02-02 02:02:02', categorycode => 'CIVILIAN', guarantorid => undef } } ); >+$builder->build({ source => 'Borrower', value => { lastseen => '2016-03-03 03:03:03', categorycode => 'CIVILIAN', guarantorid => undef } } ); > $patstodel = GetBorrowersToExpunge( { last_seen => '1999-12-12' }); > is( scalar @$patstodel, 0, 'TrackLastPatronActivity - 0 patrons must be deleted' ); > $patstodel = GetBorrowersToExpunge( { last_seen => '2016-02-15' }); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17713
:
57928
|
57932
|
57962