Bugzilla – Attachment 57939 Details for
Bug 17716
Remove itemtype-related t/db_dependent/CourseReserves.t warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17716: (followup) Remove dep on existing data and tidy
Bug-17716-followup-Remove-dep-on-existing-data-and.patch (text/plain), 3.33 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-12-02 18:35:39 UTC
(
hide
)
Description:
Bug 17716: (followup) Remove dep on existing data and tidy
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-12-02 18:35:39 UTC
Size:
3.33 KB
patch
obsolete
>From f077a1c135fad8ce5fa109c80ff7034f6ac56aea Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 2 Dec 2016 15:32:13 -0300 >Subject: [PATCH] Bug 17716: (followup) Remove dep on existing data and tidy > >This patch removes the requirement for this tests for the DB to include >at least 10 borrowers to pass. Borrowers are now created on each run >using t::lib::TestBuilder and a loop. > >Bonus: some tiny changes to tidy the file. > >To test: >- Run: > $ prove t/db_dependent/CourseReserves.t >SUCCESS => Tests pass with and without the patch. >- Sign off :-D >--- > t/db_dependent/CourseReserves.t | 42 ++++++++++++++++++++++++++--------------- > 1 file changed, 27 insertions(+), 15 deletions(-) > >diff --git a/t/db_dependent/CourseReserves.t b/t/db_dependent/CourseReserves.t >index 720fb7852f..8c47e59c90 100755 >--- a/t/db_dependent/CourseReserves.t >+++ b/t/db_dependent/CourseReserves.t >@@ -1,7 +1,19 @@ > #!/usr/bin/perl >+ >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. > # >-# This is to test C4/Members >-# It requires a working Koha database with the sample data >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; > >@@ -25,28 +37,26 @@ my $builder = t::lib::TestBuilder->new; > my $dbh = C4::Context->dbh; > $dbh->{RaiseError} = 1; > >-my $library = $builder->build( { source => 'Branch' } ); >+my $branchcode = $builder->build( { source => 'Branch' } )->{branchcode}; > my $itemtype = $builder->build( > { source => 'Itemtype', value => { notforloan => undef } } )->{itemtype}; > >-my $sth = $dbh->prepare("SELECT * FROM borrowers ORDER BY RAND() LIMIT 10"); >-$sth->execute(); >-my @borrowers = @{ $sth->fetchall_arrayref( {} ) }; >+# Create 10 sample borrowers >+my @borrowers = (); >+foreach (1..10) { >+ push @borrowers, $builder->build({ source => 'Borrower' }); >+} > >-# Create the item >-my $record = MARC::Record->new(); >-$record->append_fields( >- MARC::Field->new( '952', '0', '0', a => $library->{branchcode}, b => $library->{branchcode} ) >-); >+# Create the a record with an item >+my $record = MARC::Record->new; > my ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio($record, ''); >-my @iteminfo = C4::Items::AddItem( >- { homebranch => $library->{branchcode}, >- holdingbranch => $library->{branchcode}, >+my ( undef, undef, $itemnumber ) = C4::Items::AddItem( >+ { homebranch => $branchcode, >+ holdingbranch => $branchcode, > itype => $itemtype > }, > $biblionumber > ); >-my $itemnumber = $iteminfo[2]; > > my $course_id = ModCourse( > course_name => "Test Course", >@@ -125,3 +135,5 @@ ok( !defined( $course_reserve->{'cr_id'} ), "DelCourseReserve functions correctl > DelCourse($course_id); > $course = GetCourse($course_id); > ok( !defined( $course->{'course_id'} ), "DelCourse deleted course successfully" ); >+ >+$schema->storage->txn_rollback; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17716
:
57938
|
57939
|
57941
|
57942
|
57960
|
57961