Bugzilla – Attachment 57945 Details for
Bug 15711
Deleting patroncard images has unexpected behaviour and is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 15711: Follow up batch_id not used
SIGNED-OFF-Bug-15711-Follow-up-batchid-not-used.patch (text/plain), 1.48 KB, created by
Mark Tompsett
on 2016-12-02 19:43:59 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 15711: Follow up batch_id not used
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2016-12-02 19:43:59 UTC
Size:
1.48 KB
patch
obsolete
>From 26bc77fbf945c0b7c6f349bc28a2bd24824a468a Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 2 Dec 2016 19:37:07 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 15711: Follow up batch_id not used > >Changed batch_id to image_id in the template, as the multiparam >would catch the array case. > >TEST PLAN >--------- >1) attempt to delete a selected item, but get a warning. >2) apply this follow up >3) attempt to delete a selected item, it deletes. >4) run koha qa test tools > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt >index f3e8430..398666b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt >@@ -32,7 +32,7 @@ > return {images:images, image_ids:image_ids}; > } > else if (document.delete_images.action.checked){ >- return {images:"batch_id="+document.delete_images.action.value, image_ids:document.delete_images.action.value}; >+ return {images:"image_id="+document.delete_images.action.value, image_ids:document.delete_images.action.value}; > } > return (-1); > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15711
:
54801
|
54879
|
57877
|
57944
|
57945
|
58189
|
58190
|
58444
|
58445