Attachment 58153 Details for Bug 14876 – Bug 14876 - Show number of holds per record on the search results

[patch] Bug 14876 - Show number of holds per record on the search results

Bug-14876---Show-number-of-holds-per-record-on-the.patch (text/plain), 2.68 KB, created by Jonathan Druart on 2016-12-13 12:26:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-12-13 12:26:43 UTC

Size: 2.68 KB

patch

obsolete

>From 0aa64640681f712ebe874da7ed4bf4ce556ad593 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 31 Oct 2016 14:39:40 +0000
>Subject: [PATCH] Bug 14876 - Show number of holds per record on the search
> results
>
>This patch sues the existing plugin
>Koha::Template::Plugin::Biblio->HoldsCount
>
>To be consistent with current behaviour 'Holds (0)' is shown when
>no holds have been placed on an item
>
>To test:
>1 - Search in staff
>2 - Note holds link has no extra information
>3 - Apply patch
>4 - prove -v t/db_dependent/Template/Plugin/Holds.t
>5 - Do search in staff that returns records with some holds (i.e. place
>                some holds)
>6 - Note the number of holds now displays next to the text of the link:
>    Holds (#)
>
>Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index 031c1f8..0b3c2d3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -1,4 +1,5 @@
> [% USE Koha %]
>+[% USE Biblio %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Catalog &rsaquo; [% IF ( searchdesc ) %]Results of search [% IF ( query_desc ) %]for '[% query_desc | html %]'[% END %][% IF ( limit_desc ) %]&nbsp;with limit(s):&nbsp;'[% limit_desc | html %]'[% END %][% ELSE %]You did not specify any search criteria[% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -587,7 +588,7 @@ var holdForPatron = function () {
>                             [% IF ( SEARCH_RESULT.norequests ) %]
>                                 <span class="noholdstext">No holds allowed</span>
>                             [% ELSE %]
>-                                <a id="reserve_[% SEARCH_RESULT.biblionumber %]" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Holds</a>
>+                                <a id="reserve_[% SEARCH_RESULT.biblionumber %]" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Holds ([% Biblio.HoldsCount( SEARCH_RESULT.biblionumber ) %])</a>
>                                 [% IF ( holdfor ) %] <span class="holdforlink">| <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]&amp;findborrower=[% holdfor_cardnumber %]">Place hold for [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])</a></span>[% END %]
>                             [% END %]
> 
>-- 
>2.9.3

Actions: View | Diff | Splinter Review

Attachments on bug 14876: 53402 | 53465 | 54578 | 55889 | 55892 | 55910 | 56082 | 57000 | 58013 | 58153