Bugzilla – Attachment 58156 Details for
Bug 17726
TestBuilder's refactoring removed default values
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17726: [QA Follow-up] Add test descriptions
Bug-17726-QA-Follow-up-Add-test-descriptions.patch (text/plain), 1.16 KB, created by
Marcel de Rooy
on 2016-12-13 13:14:20 UTC
(
hide
)
Description:
Bug 17726: [QA Follow-up] Add test descriptions
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-12-13 13:14:20 UTC
Size:
1.16 KB
patch
obsolete
>From a1384088d9f3bd0cd5e6659ac4dc89d7d60dd959 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 13 Dec 2016 14:10:45 +0100 >Subject: [PATCH] Bug 17726: [QA Follow-up] Add test descriptions >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/TestBuilder.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/TestBuilder.t b/t/db_dependent/TestBuilder.t >index 4d93cee..512a8b4 100644 >--- a/t/db_dependent/TestBuilder.t >+++ b/t/db_dependent/TestBuilder.t >@@ -336,9 +336,9 @@ subtest 'Default values' => sub { > plan tests => 2; > $builder = t::lib::TestBuilder->new; > my $item = $builder->build( { source => 'Item' } ); >- is( $item->{more_subfields_xml}, undef ); >+ is( $item->{more_subfields_xml}, undef, 'This xml field should be undef' ); > $item = $builder->build( { source => 'Item', value => { more_subfields_xml => 'some xml' } } ); >- is( $item->{more_subfields_xml}, 'some xml' ); >+ is( $item->{more_subfields_xml}, 'some xml', 'Default should not overwrite assigned value' ); > }; > > $schema->storage->txn_rollback; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17726
:
58152
|
58155
| 58156 |
59300
|
59341
|
59353