Attachment 58162 Details for Bug 17761 – Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear

[patch] Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear

Bug-17761---Renewing-or-returning-item-via-the-che.patch (text/plain), 2.10 KB, created by Jonathan Druart on 2016-12-13 15:03:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-12-13 15:03:52 UTC

Size: 2.10 KB

patch

obsolete

>From bf6d2950b07172c036cd8da59165ef25fb701518 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@kylehall.info>
>Date: Mon, 12 Dec 2016 06:59:30 -0500
>Subject: [PATCH] Bug 17761 - Renewing or returning item via the checkouts
> table causes lost and damaged statuses to disappear
>
>Due to the fact that the lost and damaged status are contained within the due_due span,
>when the item is renewed or returned these statuses disappear.
>Some librarians find this disconcerting and it seems that it would be better to keep the visible.
>
>Test Plan:
>1) Find a lost item checked out to a patron
>2) Renew that lost item via the checkouts table
>3) Notice the lost status disappears from that row
>4) Apply this patch
>5) Refresh the page ( you may want to clear your browser cache as well )
>6) Renew the item again
>7) The lost status should remain visible!
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Edie Discher <edischer@cityoffargo.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>index b8416c6..de0a0a5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>@@ -203,6 +203,8 @@ $(document).ready(function() {
> due = "" + due + "";
> }
> 
>+ due = "" + due + "";
>+
> if ( oObj.lost ) {
> due += "" + oObj.lost + "";
> }
>@@ -211,7 +213,6 @@ $(document).ready(function() {
> due += "" + oObj.damaged + "";
> }
> 
>- due = "" + due + "";
> 
> return due;
> }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17761: 58112 | 58160 | 58162