Bugzilla – Attachment 58339 Details for
Bug 17804
Remove some modules from showdiffmarc.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17804: Remove some modules from showdiffmarc.pl
Bug-17804-Remove-some-modules-from-showdiffmarcpl.patch (text/plain), 2.19 KB, created by
Marcel de Rooy
on 2016-12-21 13:19:55 UTC
(
hide
)
Description:
Bug 17804: Remove some modules from showdiffmarc.pl
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-12-21 13:19:55 UTC
Size:
2.19 KB
patch
obsolete
>From e7e2023073eae9f9e71334f7f1d6fb38e4815e32 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 21 Dec 2016 14:13:23 +0100 >Subject: [PATCH] Bug 17804: Remove some modules from showdiffmarc.pl >Content-Type: text/plain; charset=utf-8 > >Remove DBI, LibXML, LibXSLT. >Add CGI's -utf8 flag. >Few whitespace changes. > >Test plan: >[1] Export an existing record to marcxml. >[2] Edit the file, make some small changes. >[3] Import it again, use a matching rule. >[4] Check the diff on Manage staged. (Here is showdiffmarc.pl) >--- > tools/showdiffmarc.pl | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > >diff --git a/tools/showdiffmarc.pl b/tools/showdiffmarc.pl >index 20abada..ec0f735 100755 >--- a/tools/showdiffmarc.pl >+++ b/tools/showdiffmarc.pl >@@ -22,8 +22,7 @@ > use Modern::Perl; > > # standard or CPAN modules used >-use CGI qw(:standard); >-use DBI; >+use CGI qw(:standard -utf8); > > # Koha modules used > use C4::Context; >@@ -31,9 +30,6 @@ use C4::Output; > use C4::Auth; > use C4::Biblio; > use C4::ImportBatch; >-use XML::LibXSLT; >-use XML::LibXML; >- > > # Input params > my $input = new CGI; >@@ -41,16 +37,13 @@ my $biblionumber = $input->param('id'); > my $importid = $input->param('importid'); > my $batchid = $input->param('batchid'); > >- > if ( not $biblionumber or not $importid ) { > print $input->redirect("/cgi-bin/koha/errors/404.pl"); > exit; > } > > # Init vars >-my ($recordBiblionumber, $recordImportid, $biblioTitle, $importTitle, $formatted1, $formatted2, >- $errorFormatted1, $errorFormatted2); >- >+my ($recordBiblionumber, $recordImportid, $biblioTitle, $importTitle, $formatted1, $formatted2, $errorFormatted1, $errorFormatted2); > > # Prepare template > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >@@ -64,7 +57,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > } > ); > >- > $recordBiblionumber = GetMarcBiblio($biblionumber, 'embed_items'); > if( $recordBiblionumber ) { > $formatted1 = $recordBiblionumber->as_formatted; >@@ -83,7 +75,6 @@ if( $importid ) { > $errorFormatted2 = 1; > } > >- > $template->param( > SCRIPT_NAME => '/cgi-bin/koha/tools/showdiffmarc.pl', > BIBLIONUMBER => $biblionumber, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17804
:
58339
|
58370
|
58411