Attachment 58386 Details for Bug 17743 – Bug 17743: Item search - Fix indexes build on MARC

[patch] Bug 17743: Item search - Fix indexes build on MARC

Bug-17743-Item-search---Fix-indexes-build-on-MARC.patch (text/plain), 1.62 KB, created by Nick Clemens (kidclamp) on 2016-12-22 13:46:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2016-12-22 13:46:47 UTC

Size: 1.62 KB

patch

obsolete

>From c2a4e4a04bda420ec1ef945a5dfae235ae7472e7 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 15 Dec 2016 10:47:24 +0000
>Subject: [PATCH] Bug 17743: Item search - Fix indexes build on MARC
>
>Searching items by custom search fields does not work because these
>fields are not correctly processed in JS.
>
>In case of custom search field, the parent of the option is not the
>select but the optgroup element.
>
>Test plan:
>Create a custom search field on 245$c for instance
>On the items search form, select this field and launch a search
>=> Without this patch, the results will not be filtered and you will get
>all your items
>=> With this patch applied, the results should be correctly filtered
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
>index 646a05f..1bb407f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
>@@ -234,7 +234,7 @@
> 
>       var params = [];
>       $form.find('select').not(':disabled').find('option:selected').each(function () {
>-        var name = $(this).parent('select').attr('name');
>+        var name = $(this).parents('select').first().attr('name');
>         var value = $(this).val();
>         params.push({ 'name': name, 'value': value });
>       });
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17743: 58242 | 58383 | 58386