Bugzilla – Attachment 58408 Details for
Bug 17808
When editing circulation conditions, only ask for confirmation when there is already a rule selected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17808: Fix behavior when editing a circ rule
Bug-17808-Fix-behavior-when-editing-a-circ-rule.patch (text/plain), 1.48 KB, created by
Jonathan Druart
on 2016-12-23 09:22:06 UTC
(
hide
)
Description:
Bug 17808: Fix behavior when editing a circ rule
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-12-23 09:22:06 UTC
Size:
1.48 KB
patch
obsolete
>From 2df80786c5154212aa52cfebc6fb9b18e406a669 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 23 Dec 2016 09:18:03 +0000 >Subject: [PATCH] Bug 17808: Fix behavior when editing a circ rule > >The original behavior is broken, see https://stackoverflow.com/questions/21410484/jquery-selector-to-find-out-count-of-non-empty-inputs > >Test plan: >Edit a circ rule >=> Without this patch you get a useless message >=> With this patch, no message >Edit a circ rule with content in inputs >=> With or without this patch you get a useful message >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index 3ee5e5f..fea8912 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -41,7 +41,7 @@ $(document).ready(function() { > $('#selectlibrary').submit(); > }); > $(".editrule").click(function(){ >- if ( $(edit_row).find("input[type='text'][value!='']").length > 0 ) { >+ if ( $("#edit_row").find("input[type='text']").filter(function(){return this.value.length > 0 }).length > 0 ) { > var edit = confirm(_("Are you sure you want to edit another rule?")); > if (!edit) return false; > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17808
:
58389
|
58408
|
58652
|
58983