Attachment 58458 Details for Bug 16826 – Bug 16826: Controllers for availability

[patch] Bug 16826: Controllers for availability

Bug-16826-Controllers-for-availability.patch (text/plain), 10.96 KB, created by Lari Taskula on 2016-12-27 16:59:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lari Taskula

Created: 2016-12-27 16:59:21 UTC

Size: 10.96 KB

patch

obsolete

>From 49c837ebf550fe1e4297e7485a0d0d62b15f4f71 Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@jns.fi>
>Date: Thu, 22 Dec 2016 15:44:36 +0200
>Subject: [PATCH] Bug 16826: Controllers for availability
>
>---
> Koha/REST/V1/BiblioAvailability.pm | 145 ++++++++++++++++++++++++++++
> Koha/REST/V1/ItemAvailability.pm   | 187 +++++++++++++++++++++++++++++++++++++
> 2 files changed, 332 insertions(+)
> create mode 100644 Koha/REST/V1/BiblioAvailability.pm
> create mode 100644 Koha/REST/V1/ItemAvailability.pm
>
>diff --git a/Koha/REST/V1/BiblioAvailability.pm b/Koha/REST/V1/BiblioAvailability.pm
>new file mode 100644
>index 0000000..8f09155
>--- /dev/null
>+++ b/Koha/REST/V1/BiblioAvailability.pm
>@@ -0,0 +1,145 @@
>+package Koha::REST::V1::BiblioAvailability;
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it under the
>+# terms of the GNU General Public License as published by the Free Software
>+# Foundation; either version 3 of the License, or (at your option) any later
>+# version.
>+#
>+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
>+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>+# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License along
>+# with Koha; if not, write to the Free Software Foundation, Inc.,
>+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>+
>+use Modern::Perl;
>+
>+use Mojo::Base 'Mojolicious::Controller';
>+
>+use C4::Auth qw( haspermission );
>+
>+use Koha::Exceptions;
>+
>+use Koha::Availability::Hold;
>+use Koha::Availability::Search;
>+
>+use Try::Tiny;
>+
>+sub search {
>+    my ($c, $args, $cb) = @_;
>+
>+    my @availabilities;
>+
>+    return try {
>+        my $biblios = $args->{'biblionumber'};
>+        foreach my $biblionumber (@$biblios) {
>+            if (my $biblio = Koha::Biblios->find($biblionumber)) {
>+                push @availabilities, Koha::Availability::Search->biblio({
>+                    biblio => $biblio
>+                })->in_opac->swaggerize;
>+            }
>+        }
>+        return $c->$cb(\@availabilities, 200);
>+    }
>+    catch {
>+        if ( $_->isa('DBIx::Class::Exception') ) {
>+            return $c->$cb( { error => $_->{msg} }, 500 );
>+        }
>+        else {
>+            return $c->$cb(
>+                { error => "Something went wrong, check the logs." }, 500 );
>+        }
>+    };
>+}
>+
>+sub hold {
>+    my ($c, $args, $cb) = @_;
>+
>+    my @availabilities;
>+    my $user = $c->stash('koha.user');
>+    my $borrowernumber = $args->{'borrowernumber'};
>+    my $to_branch = $args->{'branchcode'};
>+    my $limit_items = $args->{'limit_items'};
>+    my $patron;
>+    my $librarian;
>+
>+    return try {
>+        ($patron, $librarian) = _get_patron($c, $user, $borrowernumber);
>+
>+        my $biblios = $args->{'biblionumber'};
>+        my $params = {
>+            patron => $patron,
>+        };
>+
>+        $params->{'to_branch'} = $to_branch if $to_branch;
>+        $params->{'limit'} = $limit_items if $limit_items;
>+
>+        foreach my $biblionumber (@$biblios) {
>+            if (my $biblio = Koha::Biblios->find($biblionumber)) {
>+                $params->{'biblio'} = $biblio;
>+                my $availability = Koha::Availability::Hold->biblio($params);
>+                unless ($librarian) {
>+                    push @availabilities, $availability->in_opac->swaggerize;
>+                } else {
>+                    push @availabilities, $availability->in_intranet->swaggerize;
>+                }
>+            }
>+        }
>+
>+        return $c->$cb(\@availabilities, 200);
>+    }
>+    catch {
>+        if ( $_->isa('DBIx::Class::Exception') ) {
>+            return $c->$cb( { error => $_->{msg} }, 500 );
>+        }
>+        elsif ($_->isa('Koha::Exceptions::AuthenticationRequired')) {
>+            return $c->$cb(
>+                { error => "Authentication required." }, 401 );
>+        }
>+        elsif ($_->isa('Koha::Exceptions::NoPermission')) {
>+            return $c->$cb({
>+                error => "Authorization failure. Missing required permission(s).",
>+                required_permissions => $_->required_permissions}, 403 );
>+        }
>+        else {
>+            return $c->$cb(
>+                { error => "Something went wrong, check the logs. $_" }, 500 );
>+        }
>+    };
>+}
>+
>+sub _get_patron {
>+    my ($c, $user, $borrowernumber) = @_;
>+
>+    my $patron;
>+    my $librarian = 0;
>+
>+    unless ($user) {
>+        Koha::Exceptions::AuthenticationRequired->throw;
>+    }
>+    if (haspermission($user->userid, { borrowers => 1 })) {
>+        $librarian = 1;
>+    }
>+    if ($borrowernumber) {
>+        if ($borrowernumber == $user->borrowernumber) {
>+            $patron = $user;
>+        } else {
>+            if ($librarian) {
>+                $patron = Koha::Patrons->find($borrowernumber);
>+            } else {
>+                Koha::Exceptions::NoPermission->throw(
>+                    required_permissions => "borrowers"
>+                );
>+            }
>+        }
>+    } else {
>+        $patron = $user;
>+    }
>+
>+    return ($patron, $librarian);
>+}
>+
>+1;
>diff --git a/Koha/REST/V1/ItemAvailability.pm b/Koha/REST/V1/ItemAvailability.pm
>new file mode 100644
>index 0000000..6368f5a
>--- /dev/null
>+++ b/Koha/REST/V1/ItemAvailability.pm
>@@ -0,0 +1,187 @@
>+package Koha::REST::V1::ItemAvailability;
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it under the
>+# terms of the GNU General Public License as published by the Free Software
>+# Foundation; either version 3 of the License, or (at your option) any later
>+# version.
>+#
>+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
>+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>+# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License along
>+# with Koha; if not, write to the Free Software Foundation, Inc.,
>+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>+
>+use Modern::Perl;
>+
>+use Mojo::Base 'Mojolicious::Controller';
>+
>+use C4::Auth qw( haspermission );
>+
>+use Koha::Exceptions;
>+
>+use Koha::Availability::Checkout;
>+use Koha::Availability::Hold;
>+use Koha::Availability::Search;
>+
>+use Try::Tiny;
>+
>+sub checkout {
>+    my ($c, $args, $cb) = @_;
>+
>+    my @availabilities;
>+    my $user = $c->stash('koha.user');
>+    my $borrowernumber = $args->{'borrowernumber'};
>+    my $patron;
>+    my $librarian;
>+
>+    return try {
>+        ($patron, $librarian) = _get_patron($c, $user, $borrowernumber);
>+
>+        my $items = $args->{'itemnumber'};
>+        foreach my $itemnumber (@$items) {
>+            if (my $item = Koha::Items->find($itemnumber)) {
>+                push @availabilities, Koha::Availability::Checkout->item({
>+                    patron => $patron,
>+                    item => $item
>+                })->in_intranet->swaggerize;
>+            }
>+        }
>+        return $c->$cb(\@availabilities, 200);
>+    }
>+    catch {
>+        if ( $_->isa('DBIx::Class::Exception') ) {
>+            return $c->$cb( { error => $_->{msg} }, 500 );
>+        }
>+        elsif ($_->isa('Koha::Exceptions::AuthenticationRequired')) {
>+            return $c->$cb(
>+                { error => "Authentication required." }, 401 );
>+        }
>+        elsif ($_->isa('Koha::Exceptions::NoPermission')) {
>+            return $c->$cb({
>+                error => "Authorization failure. Missing required permission(s).",
>+                required_permissions => $_->required_permissions}, 403 );
>+        }
>+        else {
>+            return $c->$cb(
>+                { error => "Something went wrong, check the logs. $_" }, 500 );
>+        }
>+    };
>+}
>+
>+sub hold {
>+    my ($c, $args, $cb) = @_;
>+
>+    my @availabilities;
>+    my $user = $c->stash('koha.user');
>+    my $borrowernumber = $args->{'borrowernumber'};
>+    my $to_branch = $args->{'branchcode'};
>+    my $patron;
>+    my $librarian;
>+
>+    return try {
>+        ($patron, $librarian) = _get_patron($c, $user, $borrowernumber);
>+
>+        my $items = $args->{'itemnumber'};
>+        my $params = {
>+            patron => $patron,
>+        };
>+        if ($to_branch) {
>+            $params->{'to_branch'} = $to_branch;
>+        }
>+        foreach my $itemnumber (@$items) {
>+            if (my $item = Koha::Items->find($itemnumber)) {
>+                $params->{'item'} = $item;
>+                my $availability = Koha::Availability::Hold->item($params);
>+                unless ($librarian) {
>+                    push @availabilities, $availability->in_opac->swaggerize;
>+                } else {
>+                    push @availabilities, $availability->in_intranet->swaggerize;
>+                }
>+            }
>+        }
>+
>+        return $c->$cb(\@availabilities, 200);
>+    }
>+    catch {
>+        if ( $_->isa('DBIx::Class::Exception') ) {
>+            return $c->$cb( { error => $_->{msg} }, 500 );
>+        }
>+        elsif ($_->isa('Koha::Exceptions::AuthenticationRequired')) {
>+            return $c->$cb(
>+                { error => "Authentication required." }, 401 );
>+        }
>+        elsif ($_->isa('Koha::Exceptions::NoPermission')) {
>+            return $c->$cb({
>+                error => "Authorization failure. Missing required permission(s).",
>+                required_permissions => $_->required_permissions}, 403 );
>+        }
>+        else {
>+            return $c->$cb(
>+                { error => "Something went wrong, check the logs. $_" }, 500 );
>+        }
>+    };
>+}
>+
>+sub search {
>+    my ($c, $args, $cb) = @_;
>+
>+    my @availabilities;
>+
>+    return try {
>+        my $items = $args->{'itemnumber'};
>+        foreach my $itemnumber (@$items) {
>+            if (my $item = Koha::Items->find($itemnumber)) {
>+                push @availabilities, Koha::Availability::Search->item({
>+                    item => $item
>+                })->in_opac->swaggerize;
>+            }
>+        }
>+        return $c->$cb(\@availabilities, 200);
>+    }
>+    catch {
>+        if ( $_->isa('DBIx::Class::Exception') ) {
>+            return $c->$cb( { error => $_->{msg} }, 500 );
>+        }
>+        else {
>+            return $c->$cb(
>+                { error => "Something went wrong, check the logs. $_" }, 500 );
>+        }
>+    };
>+}
>+
>+sub _get_patron {
>+    my ($c, $user, $borrowernumber) = @_;
>+
>+    my $patron;
>+    my $librarian = 0;
>+
>+    unless ($user) {
>+        Koha::Exceptions::AuthenticationRequired->throw;
>+    }
>+    if (haspermission($user->userid, { borrowers => 1 })) {
>+        $librarian = 1;
>+    }
>+    if ($borrowernumber) {
>+        if ($borrowernumber == $user->borrowernumber) {
>+            $patron = $user;
>+        } else {
>+            if ($librarian) {
>+                $patron = Koha::Patrons->find($borrowernumber);
>+            } else {
>+                Koha::Exceptions::NoPermission->throw(
>+                    required_permissions => "borrowers"
>+                );
>+            }
>+        }
>+    } else {
>+        $patron = $user;
>+    }
>+
>+    return ($patron, $librarian);
>+}
>+
>+1;
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 16826: 53271 | 53276 | 53371 | 53672 | 53675 | 53813 | 53826 | 53827 | 53922 | 54053 | 56128 | 56129 | 56130 | 56295 | 57271 | 57321 | 57369 | 57370 | 57371 | 57373 | 57382 | 58456 | 58457 | 58458 | 60155 | 60156 | 60157 | 60218 | 60219 | 60267 | 60268 | 60269 | 62727