Bugzilla – Attachment 58465 Details for
Bug 17817
Repeat this Tag (cloning) not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[DO NOT PUSH] Bug 17817: This is just a try
DO-NOT-PUSH-Bug-17817-This-is-just-a-try.patch (text/plain), 1.58 KB, created by
Jonathan Druart
on 2016-12-28 10:40:28 UTC
(
hide
)
Description:
[DO NOT PUSH] Bug 17817: This is just a try
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-12-28 10:40:28 UTC
Size:
1.58 KB
patch
obsolete
>From 356d8c5a4f576ae764c38707cd4c7fc7e3f305be Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 28 Dec 2016 10:38:48 +0000 >Subject: [PATCH] [DO NOT PUSH] Bug 17817: This is just a try > >This does not work correctly: >- width is wrongly calculated >- "Move up" raises a JS error >--- > koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >index ee03961..d743caa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >@@ -253,11 +253,23 @@ function CloneField(index, hideMarc, advancedMARCEditor) { > */ > function CloneSubfield(index, advancedMARCEditor){ > var original = document.getElementById(index); //original <div> >+ var original_selects = original.getElementsByTagName('select'); >+ for( var i=0,len=original_selects.length;i<len;i++){ >+ $(original_selects[i]).select2('destroy'); >+ } >+ > var clone = original.cloneNode(true); >+ var selects = clone.getElementsByTagName('select'); >+ for( var i=0,len=selects.length;i<len;i++){ >+ $(selects[i]).select2(); >+ $(original_selects[i]).select2(); >+ } >+ >+ >+ > var new_key = CreateKey(); > // set the attribute for the new 'div' subfields > var inputs = clone.getElementsByTagName('input'); >- var selects = clone.getElementsByTagName('select'); > var textareas = clone.getElementsByTagName('textarea'); > var linkid; > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17817
:
58464
|
58465
|
58579
|
58817
|
58823
|
58824
|
58827
|
58828
|
58844
|
58845
|
58847
|
58848
|
58849
|
58863
|
58864