Bugzilla – Attachment 58522 Details for
Bug 16034
Integration with OverDrive Patron API
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
bug_16034 follow-up: Protect from unreliable OverDrive return API
bug16034-follow-up-Protect-from-unreliable-OverDri.patch (text/plain), 1.02 KB, created by
Srdjan Jankovic
on 2016-12-30 00:16:56 UTC
(
hide
)
Description:
bug_16034 follow-up: Protect from unreliable OverDrive return API
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2016-12-30 00:16:56 UTC
Size:
1.02 KB
patch
obsolete
>From f3a8f82da1bc03cd3d4b1907077178a7ebb0c21b Mon Sep 17 00:00:00 2001 >From: Srdjan <srdjan@catalyst.net.nz> >Date: Fri, 30 Dec 2016 13:03:13 +1300 >Subject: [PATCH] bug_16034 follow-up: Protect from unreliable OverDrive return > API > >--- > opac/svc/overdrive | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/opac/svc/overdrive b/opac/svc/overdrive >index 3f93c84..a4866a0 100755 >--- a/opac/svc/overdrive >+++ b/opac/svc/overdrive >@@ -104,7 +104,10 @@ eval { > $action eq 'return' && do { > my $id = $cgi->param('id') > or response_bad_request("No 'id' specified"); >- $data{action} = $od->return($id); >+ # OverDrive API for returns is very unreliable >+ local $@; >+ $data{action} = eval { $od->return($id) }; >+ $data{action} = $@ if $@; > $data{checkouts} = $od->checkouts; > $data{holds} = $od->holds; > last; >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16034
:
48919
|
48920
|
48921
|
49929
|
49930
|
49931
|
53793
|
55594
|
55675
|
55676
|
55677
|
55678
|
55763
|
55764
|
55765
|
55766
|
55815
|
55816
|
57398
|
57399
|
57400
|
57401
|
58518
|
58519
|
58520
|
58521
|
58522
|
58790
|
58791
|
59055
|
59056
|
59057
|
59058
|
59392
|
59393
|
59394
|
59395
|
59713
|
59714
|
59743
|
59744
|
59745
|
59746
|
60626
|
60654
|
60789