Bugzilla – Attachment 58624 Details for
Bug 17486
Remove 'Mozilla Persona' as an authentication method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17486: [QA Follow-up] Changes as to set_userenv
Bug-17486-QA-Follow-up-Changes-as-to-setuserenv.patch (text/plain), 2.50 KB, created by
Marcel de Rooy
on 2017-01-06 08:12:54 UTC
(
hide
)
Description:
Bug 17486: [QA Follow-up] Changes as to set_userenv
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-01-06 08:12:54 UTC
Size:
2.50 KB
patch
obsolete
>From 2852696fe1200119235b06a8d62b7d3584c0f915 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 6 Jan 2017 08:58:20 +0100 >Subject: [PATCH] Bug 17486: [QA Follow-up] Changes as to set_userenv >Content-Type: text/plain; charset=utf-8 > >Add shibboleth parameter to POD of set_userenv. >Removed a 12th set_userenv parameter from Borrower_Discharge.t. >Replaced set_userenv call in PatronLists.t looking like a fortunate typo. > >Test plan: >Run the two corrected tests. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Context.pm | 2 +- > t/db_dependent/Patron/Borrower_Discharge.t | 2 +- > t/db_dependent/PatronLists.t | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Context.pm b/C4/Context.pm >index b63b292..a50ddfd 100644 >--- a/C4/Context.pm >+++ b/C4/Context.pm >@@ -847,7 +847,7 @@ sub userenv { > C4::Context->set_userenv($usernum, $userid, $usercnum, > $userfirstname, $usersurname, > $userbranch, $branchname, $userflags, >- $emailaddress, $branchprinter); >+ $emailaddress, $branchprinter, $shibboleth); > > Establish a hash of user environment variables. > >diff --git a/t/db_dependent/Patron/Borrower_Discharge.t b/t/db_dependent/Patron/Borrower_Discharge.t >index dbdd7af..88785bd 100644 >--- a/t/db_dependent/Patron/Borrower_Discharge.t >+++ b/t/db_dependent/Patron/Borrower_Discharge.t >@@ -43,7 +43,7 @@ my $another_library = $builder->build({ source => 'Branch' }); > my $itemtype = $builder->build({ source => 'Itemtype' })->{itemtype}; > > C4::Context->_new_userenv('xxx'); >-C4::Context->set_userenv(0, 0, 0, 'firstname', 'surname', $library->{branchcode}, $library->{branchcode}, '', '', '', '', ''); >+C4::Context->set_userenv(0, 0, 0, 'firstname', 'surname', $library->{branchcode}, $library->{branchcode}, '', '', '', ''); > my $patron = $builder->build({ > source => 'Borrower', > value => { >diff --git a/t/db_dependent/PatronLists.t b/t/db_dependent/PatronLists.t >index a5bb41a..e7f4f87 100755 >--- a/t/db_dependent/PatronLists.t >+++ b/t/db_dependent/PatronLists.t >@@ -30,7 +30,7 @@ $schema->storage->txn_begin; > my $builder = t::lib::TestBuilder->new; > > C4::Context->_new_userenv('DUMMY SESSION'); >-C4::Context->set_userenv(0,0,0,'firstname','surname', 'BRANCH1', 'Library 1', 0, ', '); >+C4::Context->set_userenv( 0 ); # Koha::List::Patron only needs a number > > # Create 10 sample borrowers > my @borrowers = (); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17486
:
58183
|
58186
|
58485
|
58623
| 58624