Attachment 58626 Details for Bug 17740 – Bug 17740: Add the Koha::Patron->holds method

[patch] Bug 17740: Add the Koha::Patron->holds method

Bug-17740-Add-the-KohaPatron-holds-method.patch (text/plain), 4.02 KB, created by Marcel de Rooy on 2017-01-06 09:01:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-01-06 09:01:08 UTC

Size: 4.02 KB

patch

obsolete

>From 2b57e01f527dc06e7dc9ea17fe5e6908d615205d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 7 Dec 2016 14:42:41 +0100
>Subject: [PATCH] Bug 17740: Add the Koha::Patron->holds method
>Content-Type: text/plain; charset=utf-8
>
>The goal of this method is to replace
>C4::Reserves::GetReservesFromBorrowernumber but could be reused for
>something else, that's why it has its own bug report.
>
>Test plan:
>  prove t/db_dependent/Koha/Patrons.t
>should return green
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Rebased. Edited two test descriptions.
>---
> Koha/Patron.pm                | 14 ++++++++++
> t/db_dependent/Koha/Patrons.t | 64 ++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 77 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 698134a..ffdd7e3 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -569,6 +569,20 @@ sub account {
>     return Koha::Account->new( { patron_id => $self->borrowernumber } );
> }
> 
>+=head3 holds
>+
>+my $holds = $patron->holds
>+
>+Return all the holds placed by this patron
>+
>+=cut
>+
>+sub holds {
>+    my ($self) = @_;
>+    my $holds_rs = $self->_result->reserves->search( {}, { order_by => 'reservedate' } );
>+    return Koha::Holds->_new_from_dbic($holds_rs);
>+}
>+
> =head3 type
> 
> =cut
>diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
>index 98e1f40..e5fcba8 100644
>--- a/t/db_dependent/Koha/Patrons.t
>+++ b/t/db_dependent/Koha/Patrons.t
>@@ -19,7 +19,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 19;
>+use Test::More tests => 20;
> use Test::Warn;
> use DateTime;
> 
>@@ -594,6 +594,68 @@ subtest 'search_upcoming_membership_expires' => sub {
>     Koha::Patrons->search({ borrowernumber => { in => [ $patron_1->{borrowernumber}, $patron_2->{borrowernumber}, $patron_3->{borrowernumber} ] } })->delete;
> };
> 
>+subtest 'holds' => sub {
>+    plan tests => 3;
>+
>+    my $library = $builder->build( { source => 'Branch' } );
>+    my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
>+    my $item_1 = $builder->build(
>+        {
>+            source => 'Item',
>+            value  => {
>+                homebranch    => $library->{branchcode},
>+                holdingbranch => $library->{branchcode},
>+                biblionumber  => $biblionumber_1
>+            }
>+        }
>+    );
>+    my $item_2 = $builder->build(
>+        {
>+            source => 'Item',
>+            value  => {
>+                homebranch    => $library->{branchcode},
>+                holdingbranch => $library->{branchcode},
>+                biblionumber  => $biblionumber_1
>+            }
>+        }
>+    );
>+    my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
>+    my $item_3 = $builder->build(
>+        {
>+            source => 'Item',
>+            value  => {
>+                homebranch    => $library->{branchcode},
>+                holdingbranch => $library->{branchcode},
>+                biblionumber  => $biblionumber_2
>+            }
>+        }
>+    );
>+    my $patron = $builder->build(
>+        {
>+            source => 'Borrower',
>+            value  => { branchcode => $library->{branchcode} }
>+        }
>+    );
>+
>+    $patron = Koha::Patrons->find( $patron->{borrowernumber} );
>+    my $holds = $patron->holds;
>+    is( ref($holds), 'Koha::Holds',
>+        'Koha::Patron->holds should return a Koha::Holds objects' );
>+    is( $holds->count, 0, 'There should not be holds placed by this patron yet' );
>+
>+    C4::Reserves::AddReserve( $library->{branchcode},
>+        $patron->borrowernumber, $biblionumber_1 );
>+    # In the future
>+    C4::Reserves::AddReserve( $library->{branchcode},
>+        $patron->borrowernumber, $biblionumber_2, undef, undef, dt_from_string->add( days => 2 ) );
>+
>+    $holds = $patron->holds;
>+    is( $holds->count, 2, 'There should be 2 holds placed by this patron' );
>+
>+    $holds->delete;
>+    $patron->delete;
>+};
>+
> $retrieved_patron_1->delete;
> is( Koha::Patrons->search->count, $nb_of_patrons + 1, 'Delete should have deleted the patron' );
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17740: 58014 | 58035 | 58626