Attachment 58640 Details for Bug 17736 – Bug 17736: [QA Follow-up] Solve warning from qa tools on Holds.t

[patch] Bug 17736: [QA Follow-up] Solve warning from qa tools on Holds.t

Bug-17736-QA-Follow-up-Solve-warning-from-qa-tools.patch (text/plain), 1018 bytes, created by Marcel de Rooy on 2017-01-06 12:55:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-01-06 12:55:27 UTC

Size: 1018 bytes

patch

obsolete

>From 564a0fbb412140062c48537bc4f2fdd109e3700c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 6 Jan 2017 11:45:17 +0100
>Subject: [PATCH] Bug 17736: [QA Follow-up] Solve warning from qa tools on
> Holds.t
>Content-Type: text/plain; charset=utf-8
>
>FAIL   t/db_dependent/Holds.t
>"my" variable $hold masks earlier declaration in same scope
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Holds.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t
>index b58753f..5825f7c 100755
>--- a/t/db_dependent/Holds.t
>+++ b/t/db_dependent/Holds.t
>@@ -204,7 +204,7 @@ ok( $reserve->{'reserve_id'} eq $reserve2->{'reserve_id'}, "Test GetReserveInfo(
> 
> 
> $holds = $biblio->holds;
>-my $hold = $holds->next;
>+$hold = $holds->next;
> AlterPriority( 'top', $hold->reserve_id );
> $reserve = GetReserve( $reserve->{'reserve_id'} );
> is( $reserve->{'priority'}, '1', "Test AlterPriority(), move to top" );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17736: 58015 | 58016 | 58017 | 58056 | 58057 | 58106 | 58107 | 58108 | 58628 | 58629 | 58630 | 58631 | 58632 | 58633 | 58634 | 58635 | 58636 | 58637 | 58638 | 58639 | 58640 | 58641 | 58642 | 58643 | 58644 | 58645 | 59846 | 59847 | 59848 | 59849 | 59850 | 59851 | 59852 | 59853 | 59854 | 59855 | 59859 | 59860 | 61406 | 61407 | 61408 | 61409 | 61410 | 61411 | 61412 | 61413 | 61414 | 61415 | 61416