Attachment 58711 Details for Bug 13757 – Bug 13757: (followup) Remove warnings

[patch] Bug 13757: (followup) Remove warnings

Bug-13757-followup-Remove-warnings.patch (text/plain), 1.67 KB, created by Tomás Cohen Arazi (tcohen) on 2017-01-09 18:02:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-01-09 18:02:12 UTC

Size: 1.67 KB

patch

obsolete

>From 0ebbdacf791ef1d05fa18243136bf2dd3632c13a Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 19 Dec 2016 12:52:27 -0300
>Subject: [PATCH] Bug 13757: (followup) Remove warnings
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> opac/opac-memberentry.pl | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl
>index 2100ca8..6883724 100755
>--- a/opac/opac-memberentry.pl
>+++ b/opac/opac-memberentry.pl
>@@ -401,8 +401,10 @@ sub CheckForInvalidFields {
>     if ($borrower->{'B_email'}) {
>         push(@invalidFields, "B_email") if (!Email::Valid->address($borrower->{'B_email'}));
>     }
>-    if ( $borrower->{'password'} ne $borrower->{'password2'} ){
>-        push(@invalidFields, "password_match");
>+    if ( defined $borrower->{'password'}
>+        and $borrower->{'password'} ne $borrower->{'password2'} )
>+    {
>+        push( @invalidFields, "password_match" );
>     }
>     if ( $borrower->{'password'}  && $minpw && (length($borrower->{'password'}) < $minpw) ) {
>        push(@invalidFields, "password_invalid");
>@@ -534,9 +536,9 @@ sub GeneratePatronAttributesForm {
> sub ParsePatronAttributes {
>     my ( $cgi ) = @_;
> 
>-    my @codes = $cgi->param('patron_attribute_code');
>-    my @values = $cgi->param('patron_attribute_value');
>-    my @passwords = $cgi->param('patron_attribute_password');
>+    my @codes = $cgi->multi_param('patron_attribute_code');
>+    my @values = $cgi->multi_param('patron_attribute_value');
>+    my @passwords = $cgi->multi_param('patron_attribute_password');
> 
>     my $ea = each_array( @codes, @values, @passwords );
>     my @attributes;
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 13757: 42254 | 42626 | 42627 | 47625 | 48040 | 48041 | 48042 | 48043 | 48379 | 48380 | 48381 | 48382 | 56924 | 56925 | 56926 | 56927 | 56928 | 56929 | 57041 | 57042 | 57043 | 57044 | 57045 | 57046 | 58252 | 58253 | 58254 | 58255 | 58351 | 58352 | 58353 | 58354 | 58355 | 58356 | 58357 | 58428 | 58429 | 58581 | 58703 | 58706 | 58707 | 58708 | 58709 | 58710 | 58711 | 58712 | 58713 | 58714 | 58715 | 59376 | 59737 | 59738 | 59739 | 59813 | 59896 | 59897 | 59898 | 60359 | 60360 | 61132 | 61133 | 61134 | 61135 | 61136 | 61137 | 61138 | 61139 | 61140 | 61141 | 61142 | 61143 | 61144 | 61145 | 61146 | 61147 | 61148 | 61149 | 61150 | 61492 | 61493 | 61555 | 61556 | 61557 | 61558 | 61559 | 61560 | 61561 | 61562 | 61563 | 61564 | 61565 | 61566 | 61567 | 61568 | 61569 | 61570 | 61571 | 61572 | 61573 | 61574 | 61575