Bugzilla – Attachment 58751 Details for
Bug 15909
Remove the use of makepartialpayment
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15909 - Remove the use of makepartialpayment
Bug-15909---Remove-the-use-of-makepartialpayment.patch (text/plain), 2.94 KB, created by
Kyle M Hall (khall)
on 2017-01-10 13:48:43 UTC
(
hide
)
Description:
Bug 15909 - Remove the use of makepartialpayment
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-01-10 13:48:43 UTC
Size:
2.94 KB
patch
obsolete
>From 69bf8b98da080eb2ca8db4011268c1377408ae8d Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 24 Feb 2016 16:34:23 +0000 >Subject: [PATCH] Bug 15909 - Remove the use of makepartialpayment > >Test Plan: >1) Apply this patch >2) prove t/db_dependent/Accounts.t >3) Test fine payment via the "Pay" button, > but make the payment for less then the full amount >--- > C4/Accounts.pm | 23 ----------------------- > t/db_dependent/Accounts.t | 12 ++++-------- > 2 files changed, 4 insertions(+), 31 deletions(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index 682e59b..14487a4 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -44,7 +44,6 @@ BEGIN { > &getrefunds > &chargelostitem > &ReversePayment >- &makepartialpayment > &recordpayment_selectaccts > &WriteOffFee > &purge_zero_balance_fees >@@ -420,28 +419,6 @@ sub recordpayment_selectaccts { > ); > } > >-# makepayment needs to be fixed to handle partials till then this separate subroutine >-# fills in >-sub makepartialpayment { >- my ( $accountlines_id, $borrowernumber, $accountno, $amount, $user, $branch, $payment_note ) = @_; >- >- my $line = Koha::Account::Lines->find( $accountlines_id ); >- >- return Koha::Account->new( >- { >- patron_id => $borrowernumber, >- } >- )->pay( >- { >- amount => $amount, >- lines => [ $line ], >- note => $payment_note, >- library_id => $branch, >- } >- ); >- >-} >- > =head2 WriteOffFee > > WriteOffFee( $borrowernumber, $accountline_id, $itemnum, $accounttype, $amount, $branch, $payment_note ); >diff --git a/t/db_dependent/Accounts.t b/t/db_dependent/Accounts.t >index 6d58726..230a1d7 100644 >--- a/t/db_dependent/Accounts.t >+++ b/t/db_dependent/Accounts.t >@@ -46,7 +46,6 @@ can_ok( 'C4::Accounts', > getrefunds > ReversePayment > recordpayment_selectaccts >- makepartialpayment > WriteOffFee > purge_zero_balance_fees ) > ); >@@ -357,7 +356,7 @@ subtest "makepayment() tests" => sub { > } > }; > >-subtest "makepartialpayment() tests" => sub { >+subtest "Even more Koha::Account::pay tests" => sub { > > plan tests => 6; > >@@ -385,13 +384,10 @@ subtest "makepartialpayment() tests" => sub { > > is( $rs->count(), 1, 'Accountline created' ); > >+ my $account = Koha::Account->new( { patron_id => $borrowernumber } ); >+ my $line = Koha::Account::Lines->find( $accountline->{ accountlines_id } ); > # make the full payment >- makepartialpayment( >- $accountline->{ accountlines_id }, $borrowernumber, >- $accountline->{ accountno }, $partialamount, >- $borrowernumber, $branch, 'A payment note' ); >- >- # TODO: someone should write actual tests for makepartialpayment() >+ $account->pay({ lines => [$line], amount => $partialamount, library_id => $branch, note => 'A payment note' }); > > my $stat = $schema->resultset('Statistic')->search({ > branch => $branch, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15909
:
48353
|
52133
|
52153
|
58751
|
58753
|
58756
|
58766