Attachment 58777 Details for Bug 11708 – Bug 11708: UT: Use DateTime instead of localtime+sprintf

[patch] Bug 11708: UT: Use DateTime instead of localtime+sprintf

Bug-11708-UT-Use-DateTime-instead-of-localtimespri.patch (text/plain), 2.29 KB, created by Julian Maurice on 2017-01-10 18:39:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2017-01-10 18:39:58 UTC

Size: 2.29 KB

patch

obsolete

>From 8104de656406f300ad9b4bc17649fa92633b9c02 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Wed, 7 Sep 2016 11:57:39 +0200
>Subject: [PATCH] Bug 11708: UT: Use DateTime instead of localtime+sprintf
>
>---
> t/db_dependent/Acquisition/Basketgroups.t | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/Acquisition/Basketgroups.t b/t/db_dependent/Acquisition/Basketgroups.t
>index fdd3b0f..c494019 100755
>--- a/t/db_dependent/Acquisition/Basketgroups.t
>+++ b/t/db_dependent/Acquisition/Basketgroups.t
>@@ -2,6 +2,8 @@
> 
> use Modern::Perl;
> 
>+use DateTime;
>+
> use C4::Context;
> use C4::Acquisition;
> use C4::Bookseller qw/ AddBookseller /;
>@@ -29,8 +31,8 @@ CloseBasketgroup($basketgroupid);
> $basketgroup = GetBasketgroup($basketgroupid);
> ok($basketgroup->{closed}, "basket group is closed");
> ok(defined($basketgroup->{closeddate}), "basket group closed date is not empty");
>-my ($day, $month, $year) = (localtime)[3,4,5];
>-is($basketgroup->{closeddate}, sprintf("%04d-%02d-%02d", $year+1900, $month+1, $day), "basket group closed date is correct");
>+my $today = DateTime->now(time_zone => C4::Context->tz);
>+is($basketgroup->{closeddate}, $today->ymd, "basket group closed date is correct");
> 
> ReOpenBasketgroup($basketgroupid);
> $basketgroup = GetBasketgroup($basketgroupid);
>@@ -42,7 +44,7 @@ ModBasketgroup($basketgroup);
> $basketgroup = GetBasketgroup($basketgroupid);
> ok($basketgroup->{closed}, "basket group is closed");
> ok(defined($basketgroup->{closeddate}), "basket group closed date is not empty");
>-is($basketgroup->{closeddate}, sprintf("%04d-%02d-%02d", $year+1900, $month+1, $day), "basket group closed date is correct");
>+is($basketgroup->{closeddate}, $today->ymd, "basket group closed date is correct");
> 
> $basketgroupid = NewBasketgroup({
>     booksellerid => $booksellerid,
>@@ -52,6 +54,6 @@ $basketgroupid = NewBasketgroup({
> $basketgroup = GetBasketgroup($basketgroupid);
> ok($basketgroup->{closed}, "basket group is closed");
> ok(defined($basketgroup->{closeddate}), "basket group closed date is not empty");
>-is($basketgroup->{closeddate}, sprintf("%04d-%02d-%02d", $year+1900, $month+1, $day), "basket group closed date is correct");
>+is($basketgroup->{closeddate}, $today->ymd, "basket group closed date is correct");
> 
> $dbh->rollback;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 11708: 25115 | 25116 | 25117 | 26003 | 26004 | 26006 | 28868 | 28869 | 28870 | 28871 | 28872 | 31305 | 31306 | 31307 | 31308 | 31309 | 31530 | 31531 | 31532 | 31533 | 31534 | 31535 | 31536 | 31537 | 31538 | 31539 | 31540 | 31541 | 31542 | 31543 | 31544 | 31702 | 31703 | 31704 | 31705 | 31748 | 31749 | 31750 | 31751 | 31752 | 31753 | 32909 | 32910 | 32911 | 32912 | 32913 | 32914 | 33308 | 33309 | 33310 | 33311 | 33312 | 33313 | 34936 | 34937 | 34938 | 34939 | 34940 | 34941 | 34977 | 35748 | 35749 | 35750 | 35751 | 35752 | 35753 | 35754 | 35755 | 35756 | 35971 | 35972 | 35973 | 35974 | 35975 | 35976 | 35977 | 35978 | 35979 | 40260 | 40261 | 40262 | 40263 | 40264 | 40265 | 40266 | 40267 | 40268 | 40272 | 48992 | 48993 | 48994 | 48995 | 48996 | 52417 | 52418 | 52419 | 52420 | 52421 | 55277 | 55278 | 55279 | 58770 | 58771 | 58772 | 58773 | 58774 | 58775 | 58776 | 58777 | 58778 | 59301 | 59302 | 59303 | 59304 | 59305 | 59306 | 59307 | 59308 | 59309 | 61018 | 61019 | 61020 | 61021 | 61022 | 61023 | 61024 | 61025 | 61026 | 71260 | 71261 | 71262 | 71263 | 71264 | 71265 | 71266 | 71267 | 71268 | 72069 | 72070 | 72071 | 72072 | 72073 | 72074 | 72075 | 72076 | 72077 | 72691 | 72692 | 72693 | 72694 | 72695 | 72696 | 72697 | 72698 | 72699 | 74213 | 74214 | 74215 | 74216 | 74217 | 74218 | 74219 | 74220 | 74221 | 74222 | 74302 | 74303 | 74304 | 74305 | 74306 | 74307 | 74308 | 74309 | 74310 | 74311 | 74349 | 74350 | 74351 | 74352 | 74353 | 74354 | 74355 | 74356 | 74357 | 74358 | 75003 | 75004 | 75908 | 75909 | 78662 | 78663 | 78664 | 80697 | 80698 | 80699 | 80700 | 80979 | 80980 | 80981 | 80982 | 85786 | 85787 | 91285 | 91286 | 92378 | 92379 | 92380 | 92381 | 92382 | 93460 | 93461 | 93462 | 93463 | 93464 | 93482 | 93483 | 93484 | 93485 | 93487 | 104928 | 104929 | 104930 | 104931 | 104932 | 104933 | 104934 | 104935