Bugzilla – Attachment 5881 Details for
Bug 2601
Order fines by date and time
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-2601-Order-fines-by-date-and-time.patch (text/plain), 2.33 KB, created by
Owen Leonard
on 2011-10-13 19:52:25 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-10-13 19:52:25 UTC
Size:
2.33 KB
patch
obsolete
>From f6d7d9267c8a2478dee827c52032a5e72caa7d61 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 13 Oct 2011 15:39:29 -0400 >Subject: [PATCH] Fix for Bug 2601 - Order fines by date and time >Content-Type: text/plain; charset="utf-8" > >When a fine is paid off the modification of the original >account line containing the fine gets its amount zeroed out >and a line is added saying "Payment,thanks." Both these >transactions happen at virtually the same time, so they >cannot be ordered one after the other based on the >timestamp. > >This patch adds a one second delay bewteen the two steps, >and outputs the timestamp rather than the date of each >transaction so that it is unambiguous when each one >happened. > >NOTE: This fix will only fix the sorting of future >transactions. >--- > C4/Accounts.pm | 1 + > .../prog/en/modules/members/boraccount.tt | 2 +- > 2 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index 2352e9e..b8b09a7 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -205,6 +205,7 @@ sub makepayment { > INTO accountlines (borrowernumber, accountno, date, amount, description, accounttype, amountoutstanding) > VALUES ( ?, ?, now(), ?, 'Payment,thanks', 'Pay', 0)" > ); >+ sleep 1; > $ins->execute($borrowernumber, $nextaccntno, $payment); > $ins->finish; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >index c5941fd..9e46844 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >@@ -43,7 +43,7 @@ > [% FOREACH account IN accounts %] > > [% IF ( loop.odd ) %]<tr>[% ELSE %]<tr class="highlight">[% END %] >- <td>[% account.date %]</td> >+ <td>[% account.timestamp %]</td> > <td>[% account.description %] [% IF ( account.itemnumber ) %]<a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% account.biblionumber %]&itemnumber=[% account.itemnumber %]">View item</a> [% END %][% account.title |html %]</td> > <td>[% account.note %]</td> > [% IF ( account.amountcredit ) %]<td class="credit">[% ELSE %]<td class="debit">[% END %][% account.amount %]</td> >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2601
:
757
|
5881
|
5889
|
17109