Bugzilla – Attachment 58816 Details for
Bug 15907
Remove use of makepayment in opac/opac-account-pay-paypal-return.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15907 [QA Followup] - Simplify code and call pay() only once
Bug-15907-QA-Followup---Simplify-code-and-call-pay.patch (text/plain), 1.46 KB, created by
Kyle M Hall (khall)
on 2017-01-11 14:15:42 UTC
(
hide
)
Description:
Bug 15907 [QA Followup] - Simplify code and call pay() only once
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-01-11 14:15:42 UTC
Size:
1.46 KB
patch
obsolete
>From b6dc13330246aad0537520f378a97df182e8c738 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 11 Jan 2017 14:15:59 +0000 >Subject: [PATCH] Bug 15907 [QA Followup] - Simplify code and call pay() only > once > >--- > opac/opac-account-pay-paypal-return.pl | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > >diff --git a/opac/opac-account-pay-paypal-return.pl b/opac/opac-account-pay-paypal-return.pl >index c22453b..eb870cc 100755 >--- a/opac/opac-account-pay-paypal-return.pl >+++ b/opac/opac-account-pay-paypal-return.pl >@@ -94,16 +94,19 @@ if ( $response->is_success ) { > $amount = $params{PAYMENTINFO_0_AMT}; > > my $account = Koha::Account->new( { patron_id => $borrowernumber } ); >- foreach my $accountlines_id (@accountlines) { >- my $line = Koha::Account::Lines->find($accountlines_id); >- $account->pay( >- { >- amount => $amount, >- lines => [$line], >- note => 'PayPal' >- } >- ); >- } >+ my @lines = Koha::Account::Lines->search( >+ { >+ accountlines_id => { -in => \@accountlines } >+ } >+ ); >+ >+ $account->pay( >+ { >+ amount => $amount, >+ lines => \@lines, >+ note => 'PayPal' >+ } >+ ); > } > else { > $error = "PAYPAL_ERROR_PROCESSING"; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15907
:
48348
|
52149
|
57194
|
58816
|
58829
|
58830
|
58840