Bugzilla – Attachment 58824 Details for
Bug 17817
Repeat this Tag (cloning) not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17817: (Follow up) Fix reordering subfields issues
Bug-17817-Follow-up-Fix-reordering-subfields-issue.patch (text/plain), 1.28 KB, created by
Patricio Marrone
on 2017-01-11 15:49:51 UTC
(
hide
)
Description:
Bug 17817: (Follow up) Fix reordering subfields issues
Filename:
MIME Type:
Creator:
Patricio Marrone
Created:
2017-01-11 15:49:51 UTC
Size:
1.28 KB
patch
obsolete
>From ff44c19709a9106fa099955a94113aaa6f2c7404 Mon Sep 17 00:00:00 2001 >From: Patricio Marrone <pmarrone@unc.edu.ar> >Date: Wed, 11 Jan 2017 12:39:21 -0300 >Subject: [PATCH] Bug 17817: (Follow up) Fix reordering subfields issues > >Authority controlled subfields have invisible divs which produced >a strange behavior when reordering (multiple clicks were needed >to push a subfield up over an authority controlled subfield) >--- > koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >index 7514de7..3096277 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >@@ -423,8 +423,8 @@ function upSubfield(index) { > } > var tag = line.parentNode; // get the dad of this line. (should be "<div id='tag_...'>") > >- // getting all subfields for this tag >- var subfields = tag.querySelectorAll("div.subfield_line"); >+ // getting all visible subfields for this tag >+ var subfields = tag.querySelectorAll("div.subfield_line:not( [style*='display:none;'] )"); > var subfieldsLength = subfields.length; > > if(subfieldsLength<=1) return; // nothing to do if there is just one subfield. >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17817
:
58464
|
58465
|
58579
|
58817
|
58823
|
58824
|
58827
|
58828
|
58844
|
58845
|
58847
|
58848
|
58849
|
58863
|
58864