Attachment 58828 Details for Bug 17817 – Bug 17817: (Follow up) Fix reordering subfields issues

[patch] Bug 17817: (Follow up) Fix reordering subfields issues

Bug-17817-Follow-up-Fix-reordering-subfields-issue.patch (text/plain), 1.35 KB, created by Tomás Cohen Arazi (tcohen) on 2017-01-11 16:07:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-01-11 16:07:17 UTC

Size: 1.35 KB

patch

obsolete

>From 941d64beda4f2e20febd82f9216093ff519c4b67 Mon Sep 17 00:00:00 2001
>From: Patricio Marrone <pmarrone@unc.edu.ar>
>Date: Wed, 11 Jan 2017 12:39:21 -0300
>Subject: [PATCH] Bug 17817: (Follow up) Fix reordering subfields issues
>
>Authority controlled subfields have invisible divs which produced
>a strange behavior when reordering (multiple clicks were needed
>to push a subfield up over an authority controlled subfield)
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>index 11974050c2..38edd2b036 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>@@ -423,8 +423,8 @@ function upSubfield(index) {
>     }
>     var tag = line.parentNode; // get the dad of this line. (should be "<div id='tag_...'>")
> 
>-    // getting all subfields for this tag
>-    var subfields = tag.querySelectorAll("div.subfield_line");
>+    // getting all visible subfields for this tag
>+    var subfields = tag.querySelectorAll("div.subfield_line:not( [style*='display:none;'] )");
>     var subfieldsLength = subfields.length;
> 
>     if(subfieldsLength<=1) return; // nothing to do if there is just one subfield.
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 17817: 58464 | 58465 | 58579 | 58817 | 58823 | 58824 | 58827 | 58828 | 58844 | 58845 | 58847 | 58848 | 58849 | 58863 | 58864