Bugzilla – Attachment 58851 Details for
Bug 17882
C4::Installer::PerlModules::version_info() drops data during error handling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17882 - Add missing module test to Installer_PerlModules.t
Bug-17882---Add-missing-module-test-to-InstallerPe.patch (text/plain), 1.41 KB, created by
David Cook
on 2017-01-11 22:54:19 UTC
(
hide
)
Description:
Bug 17882 - Add missing module test to Installer_PerlModules.t
Filename:
MIME Type:
Creator:
David Cook
Created:
2017-01-11 22:54:19 UTC
Size:
1.41 KB
patch
obsolete
>From 4072d9b82892d0e6b1f1f78091ea1daca6a08ab6 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 12 Jan 2017 09:38:07 +1100 >Subject: [PATCH] Bug 17882 - Add missing module test to > Installer_PerlModules.t > >Adds a test that checks the values declared for a missing Perl >dependency. >--- > t/Installer_PerlModules.t | 9 +++++++++ > 1 file changed, 9 insertions(+) > >diff --git a/t/Installer_PerlModules.t b/t/Installer_PerlModules.t >index 1d5a00c..fd6adb4 100755 >--- a/t/Installer_PerlModules.t >+++ b/t/Installer_PerlModules.t >@@ -12,6 +12,12 @@ BEGIN { > use_ok('C4::Installer::PerlModules'); > } > >+$C4::Installer::PerlModules::PERL_DEPS->{'Local::Module::Missing'} = { >+ 'required' => '1', >+ 'min_ver' => '0.9.3', >+ 'usage' => "Checking the minimum version required for a missing module", >+}; >+ > my $modules; > ok ($modules = C4::Installer::PerlModules->new(), 'Tests modules object'); > my $prereq_pm = $modules->prereq_pm(); >@@ -37,3 +43,6 @@ my @module_list = $modules->module_list; > ok (exists($params{"DBI"}), 'DBI exists in array'); > is ($modules->required('module'=>"String::Random"),1, 'String::Random should return 1 since required'); > ok (!$modules->version_info(), "Testing empty modules"); >+ >+my $version_check = $modules->version_info('module'=>"Local::Module::Missing"); >+is($version_check->{"Local::Module::Missing"}->{"min_ver"},"0.9.3","Minimum version found for missing module"); >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17882
:
58851
|
58852
|
58853
|
58854
|
58855