Bugzilla – Attachment 58853 Details for
Bug 17882
C4::Installer::PerlModules::version_info() drops data during error handling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17882 - Fix C4::Installer::PerlModules::version_info()
Bug-17882---Fix-C4InstallerPerlModulesversioninfo.patch (text/plain), 1.70 KB, created by
David Cook
on 2017-01-11 23:09:24 UTC
(
hide
)
Description:
Bug 17882 - Fix C4::Installer::PerlModules::version_info()
Filename:
MIME Type:
Creator:
David Cook
Created:
2017-01-11 23:09:24 UTC
Size:
1.70 KB
patch
obsolete
>From b14c9258b1421d9aa2a6dc5ead4ec53450bfacb1 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 12 Jan 2017 09:38:46 +1100 >Subject: [PATCH] Bug 17882 - Fix C4::Installer::PerlModules::version_info() > >If you're doing version_info() for a single uninstalled module, >you'll currently get null values and default values instead of >the values defined in C4::Installer::PerlDependencies. > >This patch fixes the variable name for the module, and that >allows the correct data to be used. >--- > C4/Installer/PerlModules.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Installer/PerlModules.pm b/C4/Installer/PerlModules.pm >index fac0fec..386d8da 100644 >--- a/C4/Installer/PerlModules.pm >+++ b/C4/Installer/PerlModules.pm >@@ -69,7 +69,7 @@ sub version_info { > return -1 unless grep {m/$params{'module'}/} keys(%$PERL_DEPS); > eval "require $params{'module'}"; > if ($@) { >- return {$params{'module'} => {cur_ver => 0, min_ver => $PERL_DEPS->{$_}->{'min_ver'}, upgrade => 0, required => $PERL_DEPS->{$_}->{'required'}, usage => $PERL_DEPS->{$_}->{'usage'}}}; >+ return {$params{'module'} => {cur_ver => 0, min_ver => $PERL_DEPS->{$params{'module'}}->{'min_ver'}, upgrade => 0, required => $PERL_DEPS->{$params{'module'}}->{'required'}, usage => $PERL_DEPS->{$params{'module'}}->{'usage'}}}; > } > elsif ($params{'module'}->VERSION lt $PERL_DEPS->{$params{'module'}}->{'min_ver'}) { > return {$params{'module'} => {cur_ver => $params{'module'}->VERSION, min_ver => $PERL_DEPS->{$params{'module'}}->{'min_ver'}, upgrade => 1, required => $PERL_DEPS->{$params{'module'}}->{'required'}, usage => $PERL_DEPS->{$_}->{'usage'}}}; >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17882
:
58851
|
58852
|
58853
|
58854
|
58855