Bugzilla – Attachment 5888 Details for
Bug 6915
koha_perl_deps.pl truncates long module names at 26 chars
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl
Bug-6915---SIGNED-OFF-reduce-module-name-truncatio.patch (text/plain), 2.90 KB, created by
Paul Poulain
on 2011-10-14 10:22:05 UTC
(
hide
)
Description:
Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2011-10-14 10:22:05 UTC
Size:
2.90 KB
patch
obsolete
>From 049c6cc69946329df9f22b6ba024b6f7e7c3cadd Mon Sep 17 00:00:00 2001 >From: Greg Barniskis <gbarniskis@gmail.com> >Date: Mon, 26 Sep 2011 12:07:20 -0500 >Subject: [PATCH] Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl > >Widen module name allowance in the format statement, adjust other >columns to be generous but not-so-much as before, modify report >header and footer print statements to align and clarify. Very very >long module names or version numbers are still subject to possible >truncation. > >Signed-off-by: Magnus Enger <magnus@enger.priv.no> > >Sign off comment: With this patch module names are not truncated, which is an >improvement. Lines are still too long to fit an 80 column display, and so they >wrap around, but tht is a minor annoyance compared to the truncated names. > >Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> >--- > koha_perl_deps.pl | 13 +++++++------ > 1 files changed, 7 insertions(+), 6 deletions(-) > >diff --git a/koha_perl_deps.pl b/koha_perl_deps.pl >index 934dea5..c5b614e 100755 >--- a/koha_perl_deps.pl >+++ b/koha_perl_deps.pl >@@ -41,8 +41,9 @@ push @pm, 'current_pm' if $installed || $all; > > print color 'bold white' if $color; > print" >-Module Name Current Version Required Version Module Required >--------------------------------------------------------------------------------------------------------------------------- >+ Installed Required Module is >+Module Name Version Version Required >+-------------------------------------------------------------------------------------------- > "; > > my $count = 0; >@@ -60,8 +61,8 @@ foreach my $type (@pm) { > my $current_version = ($color ? $_->{$pm}->{'cur_ver'} : > $type eq 'missing_pm' || $type eq 'upgrade_pm' ? $_->{$pm}->{'cur_ver'}." *" : $_->{$pm}->{'cur_ver'}); > format = >-@<<<<<<<<<<<<<<<<<<<<<<<<< @<<<<<<<<<< @<<<<<<<<<< @<<<<< >-$pm, $current_version, $_->{$pm}->{'min_ver'}, $required >+@<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<< @<<<<< >+$pm, $current_version, $_->{$pm}->{'min_ver'}, $required > . > write; > } >@@ -69,8 +70,8 @@ write; > } > print color 'bold white' if $color; > my $footer = " >--------------------------------------------------------------------------------------------------------------------------- >-Total modules reported: $count "; >+-------------------------------------------------------------------------------------------- >+Total modules reported: $count "; > > if ($color) { > $footer .= "\n\n"; >-- >1.7.4.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6915
:
5593
|
5739
| 5888