Bugzilla – Attachment 59002 Details for
Bug 6782
Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6782: Fix fixup_cardnumber call
Bug-6782-Fix-fixupcardnumber-call.patch (text/plain), 1.15 KB, created by
Jonathan Druart
on 2017-01-16 09:09:50 UTC
(
hide
)
Description:
Bug 6782: Fix fixup_cardnumber call
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-01-16 09:09:50 UTC
Size:
1.15 KB
patch
obsolete
>From 0042c6f26e38120caa64816eb6f5ad057f1b2ce8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 16 Jan 2017 10:07:46 +0100 >Subject: [PATCH] Bug 6782: Fix fixup_cardnumber call > >The fixup_cardnumber subroutine takes only 1 parameter, the cardnumber. >This call is wrong and morevover makes a lot of tests fail: > >t/db_dependent/Letters.t .. 1/79 Can't use an undefined value as a HASH >reference at /home/vagrant/kohaclone/C4/Members.pm line 502. > >This happens because the userenv is not mocked in a lot of test files. >--- > C4/Members.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index e7609e5..4402ab9 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -499,7 +499,7 @@ sub AddMember { > > if ( C4::Context->preference("autoMemberNum") ) { > if ( not exists $data{cardnumber} or not defined $data{cardnumber} or $data{cardnumber} eq '' ) { >- $data{cardnumber} = fixup_cardnumber( $data{cardnumber}, C4::Context->userenv->{'branch'}, $data{categorycode} ); >+ $data{cardnumber} = fixup_cardnumber( $data{cardnumber} ); > } > } > >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6782
:
9945
|
10625
|
55952
|
55964
|
58173
|
58544
|
58545
| 59002