Bugzilla – Attachment 59031 Details for
Bug 17917
t/db_dependent/check_sysprefs.t fails on kohadev strangely
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17917: Fix Jenkins for t/db_dependent/Letters.t
Bug-17917-Fix-Jenkins-for-tdbdependentLetterst.patch (text/plain), 2.41 KB, created by
Mark Tompsett
on 2017-01-16 20:33:06 UTC
(
hide
)
Description:
Bug 17917: Fix Jenkins for t/db_dependent/Letters.t
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-01-16 20:33:06 UTC
Size:
2.41 KB
patch
obsolete
>From d7f94e5da18f6d0b91b3e278ae150111bcc418bc Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 16 Jan 2017 15:31:27 -0500 >Subject: [PATCH] Bug 17917: Fix Jenkins for t/db_dependent/Letters.t > >TEST PLAN >--------- >1) prove -v t/db_dependent/Letters.t > -- fail >2) apply this patch >3) prove -v t/db_dependent/Letters.t > -- success >4) run koha qa test tools >--- > t/db_dependent/Letters.t | 40 ++++++++++++++++++++++++---------------- > 1 file changed, 24 insertions(+), 16 deletions(-) > >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index 8219e5b..8afe46c 100644 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -61,15 +61,18 @@ $dbh->do(q|DELETE FROM message_transport_types|); > my $library = $builder->build({ > source => 'Branch', > }); >-my $patron_category = $builder->build({ source => 'Category' }); > my $date = dt_from_string; >-my $borrowernumber = AddMember( >- firstname => 'Jane', >- surname => 'Smith', >- categorycode => $patron_category,, >- branchcode => $library->{branchcode}, >- dateofbirth => $date, >-); >+my $patron = $builder->build({ >+ source => 'Borrower', >+ value => { >+ firstname => 'Jane', >+ surname => 'Smith', >+ branchcode => $library->{branchcode}, >+ dateofbirth => $date, >+ }, >+}); >+my $patron_category = $patron->{categorycode}; >+my $borrowernumber = $patron->{borrowernumber}; > > my $marc_record = MARC::Record->new; > my( $biblionumber, $biblioitemnumber ) = AddBiblio( $marc_record, '' ); >@@ -469,14 +472,19 @@ $dbh->do(q{INSERT INTO letter (module, code, name, title, content) VALUES ('seri > my ($serials_count, @serials) = GetSerials($subscriptionid); > my $serial = $serials[0]; > >-my $borrowernumber = AddMember( >- firstname => 'John', >- surname => 'Smith', >- categorycode => $patron_category, >- branchcode => $library->{branchcode}, >- dateofbirth => $date, >- email => 'john.smith@test.de', >-); >+my $patron = $builder->build({ >+ source => 'Borrower', >+ value => { >+ firstname => 'John', >+ surname => 'Smith', >+ categorycode => $patron_category, >+ branchcode => $library->{branchcode}, >+ dateofbirth => $date, >+ email => 'john.smith@test.de', >+ }, >+}); >+my $borrowernumber = $patron->{borrowernumber}; >+ > my $alert_id = C4::Letters::addalert($borrowernumber, 'issue', $subscriptionid); > > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17917
:
59026
|
59027
|
59028
|
59029
|
59030
|
59031
|
59039
|
59040
|
59041
|
59042
|
59044
|
59045
|
59046
|
59052
|
59062
|
59175
|
59206
|
59207
|
59274
|
59287
|
59299
|
59310
|
59311
|
59313
|
59319
|
59320
|
59321