Attachment 59068 Details for Bug 17919 – Bug 17919: (bug 17466 follow-up) Koha::Issue is now called Koha::Checkout

[patch] Bug 17919: (bug 17466 follow-up) Koha::Issue is now called Koha::Checkout

Bug-17919-bug-17466-follow-up-KohaIssue-is-now-cal.patch (text/plain), 1.56 KB, created by Jonathan Druart on 2017-01-17 08:08:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-01-17 08:08:55 UTC

Size: 1.56 KB

patch

obsolete

>From 13409bf44ad65e051d2854f149be4fc3431f51cb Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Tue, 17 Jan 2017 06:28:25 +0000
>Subject: [PATCH] Bug 17919: (bug 17466 follow-up) Koha::Issue is now called
> Koha::Checkout
>
>Ignoring the pluralization or lack thereof:
>$ git grep "Koha::Issue"
>-- This has results.
>But this was renamed by 17796, and supposedly still
>in discussion in 16870.
>
>apply this patch, and do the same git.
>There will be no results.
>
>This was found while running a prove t/db_dependent/00-strict.t
>
>Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> circ/returns.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 3794c99..de701ff 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -50,7 +50,7 @@ use C4::RotatingCollections;
> use Koha::AuthorisedValues;
> use Koha::DateUtils;
> use Koha::Calendar;
>-use Koha::Issues;
>+use Koha::Checkouts;
> 
> my $query = new CGI;
> 
>@@ -579,7 +579,7 @@ foreach ( sort { $a <=> $b } keys %returneditems ) {
>             $ri{bortitle}       = $b->{'title'};
>             $ri{bornote}        = $b->{'borrowernotes'};
>             $ri{borcategorycode}= $b->{'categorycode'};
>-            $ri{borissuescount} = Koha::Issues->count( { borrowernumber => $b->{'borrowernumber'} } );
>+            $ri{borissuescount} = Koha::Checkouts->count( { borrowernumber => $b->{'borrowernumber'} } );
>         }
>         else {
>             $ri{borrowernumber} = $riborrowernumber{$_};
>-- 
>2.9.3

Actions: View | Diff | Splinter Review

Attachments on bug 17919: 59059 | 59063 | 59068