Bugzilla – Attachment 59103 Details for
Bug 17913
Merge three authority merge fixes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 17913: Use replace_with instead of insert_grouped_field
SIGNED-OFF-Bug-17913-Use-replacewith-instead-of-in.patch (text/plain), 1.24 KB, created by
Josef Moravec
on 2017-01-17 21:13:34 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 17913: Use replace_with instead of insert_grouped_field
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-01-17 21:13:34 UTC
Size:
1.24 KB
patch
obsolete
>From 0ed84a1efb4866dbc9631638ad5671afdb7fbf6e Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Mon, 3 Jan 2011 16:32:21 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 17913: Use replace_with instead of > insert_grouped_field > >Original fix from a patch on bug 5572. >Amended by Marcel de Rooy January 2017. > >Note: This does not yet resolve the field order when merging to another >auth type, but is a good start. > >Test plan: >Run t/db_dependent/Authorities/Merge.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > C4/AuthoritiesMarc.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index e14c85f..9840d60 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -1494,8 +1494,7 @@ sub merge { > foreach my $subfield (@restore) { > $field_to->add_subfields($subfield->[0] =>$subfield->[1]); > } >- $marcrecord->delete_field($field); >- $marcrecord->insert_grouped_field($field_to); >+ $field->replace_with($field_to); > $update=1; > } > }#for each tag >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17913
:
59009
|
59010
|
59016
|
59017
|
59065
|
59066
|
59073
|
59078
|
59079
|
59080
|
59081
|
59082
|
59083
|
59084
|
59085
|
59089
|
59090
|
59102
|
59103
|
59104
|
59105
|
59106
|
59107
|
59108
|
59109
|
59110
|
59325
|
59326
|
59327
|
59328
|
59329
|
59330
|
59331
|
59332
|
59333
|
59352
|
59358
|
59360
|
59361
|
59362
|
59363
|
59364
|
59365
|
59366
|
59367
|
59368
|
59369
|
59370
|
59411
|
59412
|
59413
|
60042
|
60043
|
60341
|
60342