Bugzilla – Attachment 59136 Details for
Bug 17899
Show only mine does not work in newordersuggestion.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17899 - Show only mine does not work in newordersuggestion.pl
Bug-17899---Show-only-mine-does-not-work-in-neword.patch (text/plain), 2.10 KB, created by
Zoe Schoeler
on 2017-01-18 02:54:56 UTC
(
hide
)
Description:
Bug 17899 - Show only mine does not work in newordersuggestion.pl
Filename:
MIME Type:
Creator:
Zoe Schoeler
Created:
2017-01-18 02:54:56 UTC
Size:
2.10 KB
patch
obsolete
>From fec7db62efcb4d95a96464d23b1b91d7e2768d74 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 13 Jan 2017 16:10:20 +0100 >Subject: [PATCH] Bug 17899 - Show only mine does not work in > newordersuggestion.pl > >Bug 12775 added a link "Show only mine" in newordersuggestion.pl. >This does not work, no results. > >Also corrects the fact that click must not do default action by adding e.preventDefault(). > >Test plan : >- You must have suggestions you have accepted >- Create a new order from suggestion : /cgi-bin/koha/acqui/newordersuggestion.pl >- Click on Show only mine >=> Without patch the table is empty showing "No matching records found" >=> With patch you see only suggestions you have accpeted > >Signed-off-by: Zoe Schoeler <crazy.mental.onion@gmail.com> >--- > .../intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt >index 9ef247c..d50adf4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt >@@ -8,15 +8,17 @@ > $(document).ready(function() { > var suggestionst = $("#suggestionst").dataTable($.extend(true, {}, dataTablesDefaults, { > "aoColumnDefs": [ >- { "aTargets": [ 0 ], "bVisible": false, "bSearchable": false }, >+ { "aTargets": [ 0 ], "bVisible": false, "bSearchable": true }, // must be searchable for fnFilter > { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false }, > ], > "sPaginationType": "four_button" > } ) ); >- $("#show_only_mine").on('click', function(){ >+ $("#show_only_mine").on('click', function(e){ >+ e.preventDefault(); > suggestionst.fnFilter('^[% loggedinuser %]$', 0, true); > }); >- $("#show_all").on('click', function(){ >+ $("#show_all").on('click', function(e){ >+ e.preventDefault(); > suggestionst.fnFilter('', 0 ); > }); > }); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17899
:
58957
|
59136
|
59251