Bugzilla – Attachment 59175 Details for
Bug 17917
t/db_dependent/check_sysprefs.t fails on kohadev strangely
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17917: Fix Jenkins for t/db_dependent/Holds.t
Bug-17917-Fix-Jenkins-for-tdbdependentHoldst.patch (text/plain), 1.45 KB, created by
Mark Tompsett
on 2017-01-18 20:18:40 UTC
(
hide
)
Description:
Bug 17917: Fix Jenkins for t/db_dependent/Holds.t
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-01-18 20:18:40 UTC
Size:
1.45 KB
patch
obsolete
>From 290883d2aed3b5fd85e6595fd49f08d9a9ad398a Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 16 Jan 2017 14:44:46 -0500 >Subject: [PATCH] Bug 17917: Fix Jenkins for t/db_dependent/Holds.t > >This changes AddMember into TestBuilder calls. > >TEST PLAN >--------- >1) prove -v t/db_dependent/Holds.t > -- fails >2) apply this patch >3) prove -v t/db_dependent/Holds.t > -- works >4) run koha qa test tools >--- > t/db_dependent/Holds.t | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > >diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t >index 61b9e6e..e816322 100755 >--- a/t/db_dependent/Holds.t >+++ b/t/db_dependent/Holds.t >@@ -55,13 +55,17 @@ my ($item_bibnum, $item_bibitemnum, $itemnumber) > > # Create some borrowers > my @borrowernumbers; >-foreach (1..$borrowers_count) { >- my $borrowernumber = AddMember( >- firstname => 'my firstname', >- surname => 'my surname ' . $_, >- categorycode => $category->{categorycode}, >- branchcode => $branch_1, >- ); >+foreach my $count (1..$borrowers_count) { >+ my $patron = $builder->build({ >+ source => 'Borrower', >+ value => { >+ firstname => 'my firstname', >+ surname => 'my surname ' . $count, >+ categorycode => $category->{categorycode}, >+ branchcode => $branch_1, >+ }, >+ }); >+ my $borrowernumber = $patron->{borrowernumber}; > push @borrowernumbers, $borrowernumber; > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17917
:
59026
|
59027
|
59028
|
59029
|
59030
|
59031
|
59039
|
59040
|
59041
|
59042
|
59044
|
59045
|
59046
|
59052
|
59062
|
59175
|
59206
|
59207
|
59274
|
59287
|
59299
|
59310
|
59311
|
59313
|
59319
|
59320
|
59321