Bugzilla – Attachment 59204 Details for
Bug 17938
XSLT: Label of 583 is repeated for multiple tags and private notes don't display in staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17938 - XSLT: if 583 is repeated, the label will appear multiple times
Bug-17938---XSLT-if-583-is-repeated-the-label-will.patch (text/plain), 4.83 KB, created by
Karen
on 2017-01-19 03:43:58 UTC
(
hide
)
Description:
Bug 17938 - XSLT: if 583 is repeated, the label will appear multiple times
Filename:
MIME Type:
Creator:
Karen
Created:
2017-01-19 03:43:58 UTC
Size:
4.83 KB
patch
obsolete
>From ed86b90b3b0ddc1a47d0f71e942618d17877c6ee Mon Sep 17 00:00:00 2001 >From: Karen Jen <karenliang.student@wegc.school.nz> >Date: Thu, 19 Jan 2017 02:33:19 +0000 >Subject: [PATCH] Bug 17938 - XSLT: if 583 is repeated, the label will appear > multiple times > >Test plan >1) Edit a record >2) Repeat the Action note tag to add another Action note >3) Save record and confirm that the Action note label appears multiple >times. >4) Apply patch and refresh page >5) All Action notes should now be on one line and separated by "|" >--- > .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 31 ++++++++-------------- > .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 28 +++++++------------ > 2 files changed, 21 insertions(+), 38 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >index 162c148..387366a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >@@ -848,27 +848,18 @@ > </xsl:for-each> > </span> > </xsl:if> >+ <!-- 583 --> >+ <xsl:if test="marc:datafield[@tag=583]"> >+ <div class="results_summary action_note"> >+ <span class="label">Action note: </span> >+ <xsl:for-each select="marc:datafield[@tag=583]"> >+ <xsl:call-template name="subfieldSelectSpan"> >+ <xsl:with-param name="codes">a</xsl:with-param> >+ </xsl:call-template> >+ <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if> </xsl:for-each> >+ </div> >+ </xsl:if> > >- <!-- 583 --> >- <xsl:if test="marc:datafield[@tag=583]"> >- <xsl:for-each select="marc:datafield[@tag=583]"> >- <xsl:if test="@ind1=1 or @ind1=' '"> >- <span class="results_summary actionnote"> >- <span class="label">Action note: </span> >- <xsl:choose> >- <xsl:when test="marc:subfield[@code='z']"> >- <xsl:value-of select="marc:subfield[@code='z']"/> >- </xsl:when> >- <xsl:otherwise> >- <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">abcdefgijklnou</xsl:with-param> >- </xsl:call-template> >- </xsl:otherwise> >- </xsl:choose> >- </span> >- </xsl:if> >- </xsl:for-each> >- </xsl:if> > > <!-- 508 --> > <xsl:if test="marc:datafield[@tag=508]"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >index c62d004..48d230a 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >@@ -923,25 +923,17 @@ > </xsl:if> > > <!-- 583 --> >- <xsl:if test="marc:datafield[@tag=583]"> >- <xsl:for-each select="marc:datafield[@tag=583]"> >- <xsl:if test="@ind1=1 or @ind1=' '"> >- <span class="results_summary actionnote"> >- <span class="label">Action note: </span> >- <xsl:choose> >- <xsl:when test="marc:subfield[@code='z']"> >- <xsl:value-of select="marc:subfield[@code='z']"/> >- </xsl:when> >- <xsl:otherwise> >- <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">abcdefgijklnou</xsl:with-param> >- </xsl:call-template> >- </xsl:otherwise> >- </xsl:choose> >- </span> >+ <xsl:if test="marc:datafield[@tag=583]"> >+ <div class="results_summary action_note"> >+ <span class="label">Action note: </span> >+ <xsl:for-each select="marc:datafield[@tag=583]"> >+ <xsl:call-template name="subfieldSelectSpan"> >+ <xsl:with-param name="codes">a</xsl:with-param> >+ </xsl:call-template> >+ <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if> >+ </xsl:for-each> >+ </div> > </xsl:if> >- </xsl:for-each> >- </xsl:if> > > <!-- 508 --> > <xsl:if test="marc:datafield[@tag=508]"> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17938
:
59204
|
102025
|
102053
|
102120