Attachment 59214 Details for Bug 17933 – Bug 17933: Add test and return unless defined dob

[patch] Bug 17933: Add test and return unless defined dob

Bug-17933-Add-test-and-return-unless-defined-dob.patch (text/plain), 1.89 KB, created by Jonathan Druart on 2017-01-19 10:21:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-01-19 10:21:13 UTC

Size: 1.89 KB

patch

obsolete

>From e351534dea4aed77570d4493b8529acfcf10bba8 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 19 Jan 2017 11:13:36 +0100
>Subject: [PATCH] Bug 17933: Add test and return unless defined dob
>
>Without this patch get_age return actually 0 instead of
>---
> Koha/Patron.pm                | 4 ++--
> t/db_dependent/Koha/Patrons.t | 4 +++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 1b9ece4..28289c5 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -544,8 +544,8 @@ Return the age of the patron
> sub get_age {
>     my ($self)    = @_;
>     my $today_str = dt_from_string->strftime("%Y-%m-%d");
>-    my $dob_str   = dt_from_string( $self->dateofbirth ) || return;
>-    $dob_str      = $dob_str->strftime("%Y-%m-%d");
>+    return unless $self->dateofbirth;
>+    my $dob_str   = dt_from_string( $self->dateofbirth )->strftime("%Y-%m-%d");
> 
>     my ( $dob_y,   $dob_m,   $dob_d )   = split /-/, $dob_str;
>     my ( $today_y, $today_m, $today_d ) = split /-/, $today_str;
>diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
>index e5fcba8..8012568 100644
>--- a/t/db_dependent/Koha/Patrons.t
>+++ b/t/db_dependent/Koha/Patrons.t
>@@ -487,13 +487,15 @@ subtest 'checkouts + get_overdues' => sub {
> };
> 
> subtest 'get_age' => sub {
>-    plan tests => 6;
>+    plan tests => 7;
> 
>     my $patron = $builder->build( { source => 'Borrower' } );
>     $patron = Koha::Patrons->find( $patron->{borrowernumber} );
> 
>     my $today = dt_from_string;
> 
>+    $patron->dateofbirth( undef );
>+    is( $patron->get_age, undef, 'get_age should return undef if no dateofbirth is defined' );
>     $patron->dateofbirth( $today->clone->add( years => -12, months => -6, days => -1 ) );
>     is( $patron->get_age, 12, 'Patron should be 12' );
>     $patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 1 ) );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17933: 59172 | 59194 | 59214 | 59215 | 59733 | 59734 | 59735 | 59736 | 60356 | 60357 | 60358