Bugzilla – Attachment 59290 Details for
Bug 7556
Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7143: [QA Follow-up] Handling tabs
Bug-7143-QA-Follow-up-Handling-tabs.patch (text/plain), 17.49 KB, created by
Gracie
on 2017-01-19 22:56:41 UTC
(
hide
)
Description:
Bug 7143: [QA Follow-up] Handling tabs
Filename:
MIME Type:
Creator:
Gracie
Created:
2017-01-19 22:56:41 UTC
Size:
17.49 KB
patch
obsolete
>From 55bed56ebe0fe22a24fecb303503a45b614ee817 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 19 Jan 2017 10:56:30 +0100 >Subject: [PATCH] Bug 7143: [QA Follow-up] Handling tabs > >Editing spaces before releases and developer: >876,$s/ \+releases$/^Ireleases/ (20 substitutions) >876,$s/ \+developer$/^Ideveloper/ (7 substitutions on 7 lines) > >Editing spaces between date and text: >876,$s/2016 \+/2016^I/ >876,$s/2017 \+/2017^I/ >Fixed a few single spaces too. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Display on Timeline tab looks good now. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >https://bugs.koha-community.org/show_bug.cgi?id=7556 >--- > docs/history.txt | 54 +++++++++++----------- > .../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 8 +++- > .../bootstrap/en/modules/opac-readingrecord.tt | 1 + > .../en/modules/opac-registration-confirmation.tt | 8 +++- > .../bootstrap/en/modules/opac-request-article.tt | 3 ++ > .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 3 ++ > .../bootstrap/en/modules/opac-results-grouped.tt | 1 + > .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 5 ++ > .../opac-tmpl/bootstrap/en/modules/opac-review.tt | 1 + > .../bootstrap/en/modules/opac-search-history.tt | 1 + > .../bootstrap/en/modules/opac-sendbasketform.tt | 8 +++- > .../bootstrap/en/modules/opac-sendshelfform.tt | 8 +++- > .../bootstrap/en/modules/opac-serial-issues.tt | 8 +++- > .../bootstrap/en/modules/opac-shareshelf.tt | 1 + > .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 3 ++ > .../bootstrap/en/modules/opac-suggestions.tt | 3 ++ > .../opac-tmpl/bootstrap/en/modules/opac-tags.tt | 1 + > .../bootstrap/en/modules/opac-tags_subject.tt | 8 +++- > .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 1 + > .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 3 ++ > 20 files changed, 96 insertions(+), 33 deletions(-) > >diff --git a/docs/history.txt b/docs/history.txt >index fc58fa3..5f6e5c7 100644 >--- a/docs/history.txt >+++ b/docs/history.txt >@@ -873,30 +873,30 @@ June 10 2016 Nguyen Duy Tinh becomes the 303rd developer to have a patch pushed > June 22 2016 Koha 3.20.12 released releases > June 24 2016 Koha 16.05.1 released releases > June 24 2016 Koha 3.22.8 released releases >-July 24 2016 Koha 3.20.13 released releases >-July 31 2016 Koha 3.22.9 released releases >-August 1 2016 Koha 16.05.02 released releases >-August 3 2016 Koha 16.05.02-01 released releases >-August 22 2016 Koha 3.20.14 released releases >-August 23 2016 Koha 16.05.03 released releases >-August 23 2016 Koha 3.22.10 released releases >-September 2 2016 Andreas Roussos becomes the 304th developer to have a patch pushed developer >-September 9 2016 Lee Jamison becomes the 305th developer to have a patch pushed developer >-September 21 2016 Koha 3.20.15 released releases >-September 22 2016 Koha 16.05.04 released releases >-September 23 2016 Koha 3.22.11 released releases >-October 21 2016 Rodrigo Santellan becomes the 306th developer to have a patch pushed developer >-October 22 2016 Koha 16.05.05 released releases >-October 23 2016 Koha 16.05.05-01 released releases >-October 24 2016 Koha 3.22.12 released releases >-November 7 2016 Radek Å iman becomes the 307th developer to have a patch pushed developer >-November 22 2016 Koha 16.11.00 released releases >-November 30 2016 Koha 3.22.13 released releases >-December 12 2016 Koha 16.05.06 released releases >-December 14 2016 Koha 16.05.06-01 released releases >-December 16 2016 Chris Kirby becomes the 308th developer to have a patch pushed developer >-December 22 2016 Koha 16.11.01 released releases >-December 23 2016 Tim McMahon becomes the 309th developer to have a patch pushed developer >-December 23 2016 Dani Elder becomes the 310th developer to have a patch pushed developer >-January 2 2017 Koha 3.22.14 released releases >-January 3 2017 Koha 16.05.07 released releases >+July 24 2016 Koha 3.20.13 released releases >+July 31 2016 Koha 3.22.9 released releases >+August 1 2016 Koha 16.05.02 released releases >+August 3 2016 Koha 16.05.02-01 released releases >+August 22 2016 Koha 3.20.14 released releases >+August 23 2016 Koha 16.05.03 released releases >+August 23 2016 Koha 3.22.10 released releases >+September 2 2016 Andreas Roussos becomes the 304th developer to have a patch pushed developer >+September 9 2016 Lee Jamison becomes the 305th developer to have a patch pushed developer >+September 21 2016 Koha 3.20.15 released releases >+September 22 2016 Koha 16.05.04 released releases >+September 23 2016 Koha 3.22.11 released releases >+October 21 2016 Rodrigo Santellan becomes the 306th developer to have a patch pushed developer >+October 22 2016 Koha 16.05.05 released releases >+October 23 2016 Koha 16.05.05-01 released releases >+October 24 2016 Koha 3.22.12 released releases >+November 7 2016 Radek Å iman becomes the 307th developer to have a patch pushed developer >+November 22 2016 Koha 16.11.00 released releases >+November 30 2016 Koha 3.22.13 released releases >+December 12 2016 Koha 16.05.06 released releases >+December 14 2016 Koha 16.05.06-01 released releases >+December 16 2016 Chris Kirby becomes the 308th developer to have a patch pushed developer >+December 22 2016 Koha 16.11.01 released releases >+December 23 2016 Tim McMahon becomes the 309th developer to have a patch pushed developer >+December 23 2016 Dani Elder becomes the 310th developer to have a patch pushed developer >+January 2 2017 Koha 3.22.14 released releases >+January 3 2017 Koha 16.05.07 released releases >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt >index 38ca4fa..7464099 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt >@@ -105,4 +105,10 @@ > </div> <!-- / .main --> > > [% INCLUDE 'opac-bottom.inc' %] >-[% BLOCK jsinclude %][% END %] >+[% BLOCK jsinclude %] >+ <script type="text/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }); >+ </script> >+[% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >index c4a7419..178bdf4 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >@@ -174,6 +174,7 @@ > <script type="text/javascript"> > //<![CDATA[ > $(document).ready(function(){ >+ $('form').preventDoubleFormSubmit(); > [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %] > $('#sortsubmit').hide(); > $('#order').change(function() { >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >index 7ce46b7..5ef1163 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >@@ -105,4 +105,10 @@ > </div> <!-- /.main --> > > [% INCLUDE 'opac-bottom.inc' %] >-[% BLOCK jsinclude %][% END %] >+[% BLOCK jsinclude %] >+ <script type="text/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }): >+ </script> >+[% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >index 4451e74..cab7eb6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >@@ -187,6 +187,9 @@ > > [% BLOCK jsinclude %] > <script type="text/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }); > // <![CDATA[ > allow_submit = false; > $('#place-article-request').on('submit', function( event ){ >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index c0dd300..665f7a5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -416,6 +416,9 @@ > [% BLOCK jsinclude %] > [% INCLUDE 'calendar.inc' %] > <script type="text/javascript"> >+ $(document).ready(fucntion() { >+ $('form').preventDoubleFormSubmit(); >+ }); > // <![CDATA[ > var MSG_NO_ITEM_SELECTED = _("Expecting a specific item selection."); > var ForceHoldNotesReasons=new Array( >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt >index 8595f9a..52b9a3d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt >@@ -276,6 +276,7 @@ href="/cgi-bin/koha/opac-rss.pl?[% query_cgi %][% limit_cgi |html %]" /> > var q_array = new Array(); // will hold the search terms, if possible > > $(document).ready(function(){ >+ $('form').preventDoubleFormSubmit(); > [% IF ( OpacHighlightedWords ) %] > $('a.title').each(function() { > $(this).attr("href", $(this).attr("href") + "&query_desc=[% query_desc | uri %]"); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 2d85671..a960826 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -581,6 +581,11 @@ > > [% INCLUDE 'opac-bottom.inc' %] > [% BLOCK jsinclude %] >+<script type="text/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }); >+</script> > [% IF ( LibraryThingForLibrariesID ) %] > [% IF ( using_https ) %] > <script src="https://ltfl.librarything.com/forlibraries/widget.js?id=[% LibraryThingForLibrariesID %]&systype=koha" type="text/javascript"></script> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt >index 7e537b6..b07d1e5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt >@@ -67,6 +67,7 @@ > <script type="text/javascript"> > //<![CDATA[ > $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); > [% IF WINDOW_CLOSE %] > opener.location.reload(); > window.close(); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >index d8d6c57..2a7ac56 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >@@ -220,6 +220,7 @@ > //<![CDATA[ > var MSG_CONFIRM_DELETE_HISTORY = _("Are you sure you want to delete selected search history entries?"); > $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); > // We show table ordered by descending dates by default > // (so that the more recent query is shown first) > $(".historyt").dataTable($.extend(true, {}, dataTablesDefaults, { >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt >index fed5013..9039044 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt >@@ -50,4 +50,10 @@ > </div> <!-- / .main --> > > [% INCLUDE 'opac-bottom.inc' is_popup=1 %] >-[% BLOCK jsinclude %][% END %] >+[% BLOCK jsinclude %] >+ <script type="text/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }); >+ </script> >+[% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt >index c5e9fe8..da53cca 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt >@@ -55,4 +55,10 @@ > </div> <!-- / .main --> > > [% INCLUDE 'opac-bottom.inc' is_popup=1 %] >-[% BLOCK jsinclude %][% END %] >+[% BLOCK jsinclude %] >+ <script type="text/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }); >+ </script> >+[% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt >index 4517ffc..70bb95f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt >@@ -159,4 +159,10 @@ > </div> <!-- / .main --> > > [% INCLUDE 'opac-bottom.inc' %] >-[% BLOCK jsinclude %][% END %] >+[% BLOCK jsinclude %] >+ <script type="test/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }); >+ </script> >+[% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt >index 8ac96db..49ad105 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt >@@ -94,6 +94,7 @@ > <script type="text/javascript"> > //<![CDATA[ > $(document).ready(function(){ >+ $('form').preventDoubleFormSubmit(); > $("#share_list").on('submit', function(e) { > var address = $("#invite_address").val(); > if ( address.length == 0) { >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index 0e20fcf..aab4879 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -750,6 +750,9 @@ > [% BLOCK jsinclude %] > <script type="text/javascript" src="[% interface %]/[% theme %]/lib/jquery/plugins/jquery.checkboxes.min.js"></script> > <script type="text/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }); > //<![CDATA[ > var MSG_REMOVE_FROM_LIST = _("Are you sure you want to remove these items from the list?"); > var MSG_REMOVE_ONE_FROM_LIST = _("Are you sure you want to remove this item from the list?"); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index fa9da1f..8f28197 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -275,6 +275,9 @@ > <script type="text/javascript" src="[% interface %]/[% theme %]/lib/jquery/plugins/jquery.checkboxes.min.js"></script> > [% INCLUDE 'datatables.inc' %] > <script type="text/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }); > //<![CDATA[ > [% IF ( loggedinusername ) %] > function enableCheckboxActions(){ >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >index 052acd6..c59d74b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >@@ -173,6 +173,7 @@ > //<![CDATA[ > > $(document).ready(function(){ >+ $('form').preventDoubleFormSubmit(); > var MSG_DELETE_TAG = _("Are you sure you want to delete this tag?"); > $(".delete").on("click", function(){ > return confirmDelete(MSG_DELETE_TAG); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags_subject.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags_subject.tt >index f3194b2..1e7f684 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags_subject.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags_subject.tt >@@ -58,4 +58,10 @@ > </div> <!-- / .main --> > > [% INCLUDE 'opac-bottom.inc' %] >-[% BLOCK jsinclude %][% END %] >+[% BLOCK jsinclude %] >+ <script type="text/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }); >+ </script> >+[% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index ef24771..4cd8969 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -837,6 +837,7 @@ Using this account is not recommended because some parts of Koha will not functi > var MSG_CONFIRM_RESUME_HOLDS = _("Are you sure you want to resume all suspended holds?"); > > $(document).ready(function(){ >+ $('form').preventDoubleFormSubmit(); > $('#opac-user-views').tabs(); > $(".js-show").show(); > $(".js-hide").hide(); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index d97c5f1..6082a9f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -329,6 +329,9 @@ > [% BLOCK jsinclude %] > [% INCLUDE 'datatables.inc' %] > <script type="text/javascript"> >+ $(document).ready(function() { >+ $('form').preventDoubleFormSubmit(); >+ }): > //<![CDATA[ > function mungeHistory() { > // prevent back button from allowing form resubmission >-- >2.1.4
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=59290">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7556
:
59289
| 59290