Bugzilla – Attachment 59311 Details for
Bug 17917
t/db_dependent/check_sysprefs.t fails on kohadev strangely
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t
Bug-17917-AMENDED-Fix-path-issue-in-tdbdependentch.patch (text/plain), 1.76 KB, created by
Marcel de Rooy
on 2017-01-20 09:27:09 UTC
(
hide
)
Description:
Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-01-20 09:27:09 UTC
Size:
1.76 KB
patch
obsolete
>From ff4fccec7781e85a128770b000131de5bc666672 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 19 Jan 2017 00:38:52 +0000 >Subject: [PATCH] Bug 17917: [AMENDED] Fix path issue in > t/db_dependent/check_sysprefs.t >Content-Type: text/plain; charset=utf-8 > >EDIT (from Marcel:) > >Previous patch fixes issue caused by Search.t. >This patch still adds some small changes to check_sysprefs.t. > >Signed-off-by: Grace McKenzie <grace.mcky@gmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/check_sysprefs.t | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/check_sysprefs.t b/t/db_dependent/check_sysprefs.t >index a53c575..b179c4a 100755 >--- a/t/db_dependent/check_sysprefs.t >+++ b/t/db_dependent/check_sysprefs.t >@@ -17,9 +17,9 @@ > # with this program; if not, write to the Free Software Foundation, Inc., > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > >-use strict; >-use warnings; >+use Modern::Perl; > >+use Carp; > use Getopt::Long; > use C4::Context; > >@@ -33,12 +33,13 @@ our $dbh = C4::Context->dbh; > my $root_dir = C4::Context->config('intranetdir') . '/installer/data/mysql'; > my $base_syspref_file = "sysprefs.sql"; > >-open( my $ref_fh, "<$root_dir/$base_syspref_file" ); >+open my $ref_fh, '<', "$root_dir/$base_syspref_file" or croak "Can't open '$root_dir/$base_syspref_file': $!"; > my $ref_syspref = get_syspref_from_file($ref_fh); > my @ref_sysprefs = sort { lc $a cmp lc $b } keys %$ref_syspref; >+my $num_sysprefs = scalar @ref_sysprefs; > if ( !$showsql ) { >- cmp_ok( $#ref_sysprefs, '>=', 0, >- "Found " . ( $#ref_sysprefs + 1 ) . " sysprefs" ); >+ cmp_ok( $num_sysprefs, '>', 0, >+ "Found $num_sysprefs sysprefs" ); > } > > check_db($ref_syspref); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17917
:
59026
|
59027
|
59028
|
59029
|
59030
|
59031
|
59039
|
59040
|
59041
|
59042
|
59044
|
59045
|
59046
|
59052
|
59062
|
59175
|
59206
|
59207
|
59274
|
59287
|
59299
|
59310
|
59311
|
59313
|
59319
|
59320
|
59321