Bugzilla – Attachment 5945 Details for
Bug 6963
When creating a new order, the item isn't added if its barcode already exists in the items table.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Follow-up patch : use the subfield associated with items.barcode
SIGNED-OFF-Follow-up-patch--use-the-subfield-assoc.patch (text/plain), 2.46 KB, created by
Katrin Fischer
on 2011-10-17 20:47:57 UTC
(
hide
)
Description:
[SIGNED-OFF] Follow-up patch : use the subfield associated with items.barcode
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2011-10-17 20:47:57 UTC
Size:
2.46 KB
patch
obsolete
>From 4f26733171a6157ee6a1c38e69f06e9fd3d10a7f Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9rick=20Capovilla?= <frederick.capovilla@libeo.com> >Date: Mon, 17 Oct 2011 16:01:29 -0400 >Subject: [PATCH] [SIGNED-OFF] Follow-up patch : use the subfield associated > with items.barcode > >Instead of using the 'p' subfield directly, use the subfield letter >associated with the items.barcode column. > >http://bugs.koha-community.org/show_bug.cgi?id=6963 >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> > >Test cases tested: >- 1 item, barcode empty >- 2 items, barcodes both empty >- 1 item, existing barcode >- 1 item, new barcode >- 2 items, one barcode empty, one existing > >All test cases worked nicely and gave correct error messages. >--- > acqui/neworderempty.pl | 4 ++++ > .../prog/en/modules/acqui/neworderempty.tt | 2 +- > 2 files changed, 5 insertions(+), 1 deletions(-) > >diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl >index 6361125..592758e 100755 >--- a/acqui/neworderempty.pl >+++ b/acqui/neworderempty.pl >@@ -333,6 +333,9 @@ if (C4::Context->preference('AcqCreateItem') eq 'ordering' && !$ordernumber) { > my @itemtypes; > @itemtypes = C4::ItemType->all unless C4::Context->preference('item-level_itypes'); > >+# Find the items.barcode subfield for barcode validations >+my (undef, $barcode_subfield) = GetMarcFromKohaField('items.barcode', ''); >+ > # fill template > $template->param( > close => $close, >@@ -385,6 +388,7 @@ $template->param( > ecost => $data->{'ecost'}, > notes => $data->{'notes'}, > publishercode => $data->{'publishercode'}, >+ barcode_subfield => $barcode_subfield, > > import_batch_id => $import_batch_id, > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >index ed5ee82..58b8493 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >@@ -53,7 +53,7 @@ function Check(ff) { > if (ff.field_value[i].value.length == 0 && ff.mandatory[i].value == 1) { > empty_item_mandatory++; > } >- if(ff.subfield[i].value === 'p' && ff.field_value[i].value.length != 0) { >+ if(ff.subfield[i].value === '[% barcode_subfield %]' && ff.field_value[i].value.length != 0) { > barcodes.push(ff.field_value[i].value); > } > } >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6963
:
5682
|
5806
|
5838
|
5944
|
5945
|
5946
|
5947
|
5954