Bugzilla – Attachment 59503 Details for
Bug 17840
Add classes to internal and public notes in checkouts table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 17840: adding classes to notes in checkouts
SIGNED-OFF-Bug-17840-adding-classes-to-notes-in-ch.patch (text/plain), 2.21 KB, created by
Owen Leonard
on 2017-01-24 14:44:11 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 17840: adding classes to notes in checkouts
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2017-01-24 14:44:11 UTC
Size:
2.21 KB
patch
obsolete
>From 6e73798d6e2cbe8380a3cb1eea0f128986b855d2 Mon Sep 17 00:00:00 2001 >From: Emma Smith <emma.nakamura.smith@gmail.com> >Date: Tue, 17 Jan 2017 03:23:18 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 17840: adding classes to notes in checkouts > >Test Plan >1) Add an internal and a public note to an item. >2) Check out the item. >3) Verify that both notes are shown in between title and barcode in the >second column of the details table. >4) Verify there is an empty class="" in the HTML source code for each >5) Apply patch and refresh page >6) View page source, confirm that class has been changed > >I tested this by first applying the patch for bug 17919 to catch the >check-in software error. Patch working as expected :) > >Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index f12743f..1ef2375 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -239,18 +239,12 @@ $(document).ready(function() { > } > > if ( oObj.itemnotes ) { >- var span_class = ""; >- if ( $.datepicker.formatDate('yy-mm-dd', new Date(oObj.issuedate) ) == ymd ) { >- span_class = "circ-hlt"; >- } >+ var span_class = "text-muted"; > title += " - <span class='" + span_class + "'>" + oObj.itemnotes + "</span>" > } > > if ( oObj.itemnotes_nonpublic ) { >- var span_class = ""; >- if ( $.datepicker.formatDate('yy-mm-dd', new Date(oObj.issuedate) ) == ymd ) { >- span_class = "circ-hlt"; >- } >+ var span_class = "text-danger"; > title += " - <span class='" + span_class + "'>" + oObj.itemnotes_nonpublic + "</span>" > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17840
:
59053
|
59054
|
59152
|
59284
|
59286
|
59503
|
60619