Bugzilla – Attachment 59532 Details for
Bug 16018
Merge.pl code cleanup
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16018: Add a TODO for need_merge_authorities in merge.pl
Bug-16018-Add-a-TODO-for-needmergeauthorities-in-m.patch (text/plain), 1.35 KB, created by
Mehdi Hamidi
on 2017-01-24 22:47:48 UTC
(
hide
)
Description:
Bug 16018: Add a TODO for need_merge_authorities in merge.pl
Filename:
MIME Type:
Creator:
Mehdi Hamidi
Created:
2017-01-24 22:47:48 UTC
Size:
1.35 KB
patch
obsolete
>From bfed8054d6670de71478a158bfb671fd938e1e38 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 24 Jan 2017 14:53:33 +0100 >Subject: [PATCH] Bug 16018: Add a TODO for need_merge_authorities in merge.pl > >It is not useful to postpone a merge to the cron job here, since the >old authority record is deleted and merge_authority cannot yet handle >that correctly. But no harm either to leave it here. > >Note: This will be addressed shortly on bug 9988. So please help! > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: mehdi <mehdi@inlibro.com> >--- > authorities/merge.pl | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/authorities/merge.pl b/authorities/merge.pl >index 60bc6db..3996131 100755 >--- a/authorities/merge.pl >+++ b/authorities/merge.pl >@@ -66,6 +66,9 @@ if ($merge) { > my $MARCfrom = GetAuthority( $recordid2 ); > &merge( $recordid2, $MARCfrom, $recordid1, $record ); > } else { >+ # What follows, is actually useless. Because our cron job cannot handle >+ # it adequately. But it does not harm either. Will just be ignored. >+ # FIXME Restructure need_merge_authorities on bug 9988 > my $dbh = C4::Context->dbh; > my $sqlinsert = "INSERT INTO need_merge_authorities (authid, done) VALUES (?,?)"; > $dbh->do( $sqlinsert, undef, ( $recordid1, 0 ) ); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16018
:
48889
|
58578
|
59497
|
59502
|
59531
|
59532
|
59547
|
59927
|
59930
|
59935