Bugzilla – Attachment 59545 Details for
Bug 17986
Perl dependency evaluation incorrect
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17986: Perl dependency evaluation incorrect
Bug-17986-Perl-dependency-evaluation-incorrect.patch (text/plain), 1.90 KB, created by
Jonathan Druart
on 2017-01-25 11:40:18 UTC
(
hide
)
Description:
Bug 17986: Perl dependency evaluation incorrect
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-01-25 11:40:18 UTC
Size:
1.90 KB
patch
obsolete
>From 4224c409d763290d8d53ae741f61947b65044e30 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Wed, 25 Jan 2017 09:58:40 +1100 >Subject: [PATCH] Bug 17986: Perl dependency evaluation incorrect > >It looks like I made a copy/paste error in a previous patch. > >While the fix was working when you pass the param "module" to >version_info, it wasn't populating the version correctly >for the "all" param, which causes koha_perl_deps.pl to >think all OK modules actually need an upgrade. > >TEST PLAN > >0) Be on a system where you know your Koha Perl dependencies are >mostly up-to-date > >1) Run ./koha_perl_deps.pl -a -c >2) Note that most modules say they need an upgrade even when >the installed version is the same as the minimum version > >3) Apply patch > >4) Run ./koha_perl_deps.pl -a -c >5) Note that most moduls say they're OK, especially when the >installed version is the same or greater than the minimum version > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Running koha_perl_deps.pl -u convinced me. >--- > C4/Installer/PerlModules.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Installer/PerlModules.pm b/C4/Installer/PerlModules.pm >index 9d8d1c8..2a64826 100644 >--- a/C4/Installer/PerlModules.pm >+++ b/C4/Installer/PerlModules.pm >@@ -84,7 +84,7 @@ sub version_info { > for (sort keys(%{$PERL_DEPS})) { > my $pkg = $_; # $_ holds the string > eval "require $pkg"; >- my $pkg_version = $params{'module'} && $params{'module'}->can("VERSION") ? $params{'module'}->VERSION : 0; >+ my $pkg_version = $pkg && $pkg->can("VERSION") ? $pkg->VERSION : 0; > my $min_version = $PERL_DEPS->{$_}->{'min_ver'} // 0; > if ($@) { > push (@{$self->{'missing_pm'}}, {$_ => {cur_ver => 0, min_ver => $PERL_DEPS->{$_}->{'min_ver'}, required => $PERL_DEPS->{$_}->{'required'}, usage => $PERL_DEPS->{$_}->{'usage'}}}); >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17986
:
59535
|
59536
|
59538
|
59544
| 59545