Bugzilla – Attachment 59550 Details for
Bug 17993
Do not use modal authentication with CAS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17993 - Do not use modal authentication with CAS - tags
Bug-17993---Do-not-use-modal-authentication-with-C.patch (text/plain), 2.26 KB, created by
Fridolin Somers
on 2017-01-25 13:49:45 UTC
(
hide
)
Description:
Bug 17993 - Do not use modal authentication with CAS - tags
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2017-01-25 13:49:45 UTC
Size:
2.26 KB
patch
obsolete
>From 617257f08cf1f1e6f123901ceed513dbe74d4902 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 25 Jan 2017 14:47:02 +0100 >Subject: [PATCH] Bug 17993 - Do not use modal authentication with CAS - tags > >Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. >This must also be corrected in link for tags in detail page : "Log in to add tags" > >Test plan : >- Enable syspref casAuthentication >- Go to OPAC >- Go to a record detail page opac-detail.pl >- Click on "Log in to add tags" >=> Without patch you get the modal login popup >=> With patch you go to the login page opac-user.pl >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index e4fb61f..e6c23f7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -414,7 +414,14 @@ > </span> > <a class="tag_add" id="tag_add[% biblionumber %]" href="#">Add tag(s)</a> > [% ELSE %] >- <span id="login4tags"><a class="loginModal-trigger" data-toggle="modal" role="button" href="/cgi-bin/koha/opac-user.pl">Log in to add tags.</a></span> >+ <span id="login4tags"> >+ [% IF Koha.Preference('casAuthentication') %] >+ [%# CAS authentication is too complicated for modal window %] >+ <a href="/cgi-bin/koha/opac-user.pl">Log in to add tags.</a> >+ [% ELSE %] >+ <a class="loginModal-trigger" data-toggle="modal" role="button" href="/cgi-bin/koha/opac-user.pl">Log in to add tags.</a> >+ [% END %] >+ </span> > [% END %] > [% END # / IF TagsInputEnabled %] > </div> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17993
:
59549
|
59550
|
59719
|
59720
|
61642
|
62296
|
62867
|
62868
|
62869