Bugzilla – Attachment 59558 Details for
Bug 17782
Patron updated_on field should be set to current timestamp when borrower is deleted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17782 - (QA Followup)
Bug-17782---QA-Followup.patch (text/plain), 1.86 KB, created by
Nick Clemens (kidclamp)
on 2017-01-25 16:00:59 UTC
(
hide
)
Description:
Bug 17782 - (QA Followup)
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-01-25 16:00:59 UTC
Size:
1.86 KB
patch
obsolete
>From 7e03e97fe4cdabeb6924645dfbc34f05cdeb7770 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 25 Jan 2017 15:59:42 +0000 >Subject: [PATCH] Bug 17782 - (QA Followup) > >Fix tests > >prove t/db_dependent/Koha/Patrons.t >--- > t/db_dependent/Koha/Patrons.t | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t >index e5fcba8..f666507 100644 >--- a/t/db_dependent/Koha/Patrons.t >+++ b/t/db_dependent/Koha/Patrons.t >@@ -318,14 +318,17 @@ subtest 'renew_account' => sub { > }; > > subtest "move_to_deleted" => sub { >- plan tests => 2; >- my $patron = $builder->build( { source => 'Borrower' } ); >+ plan tests => 3; >+ my $originally_updated_on = '2016-01-01 12:12:12'; >+ my $patron = $builder->build( { source => 'Borrower',value => { updated_on => $originally_updated_on } } ); > my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} ); > is( ref( $retrieved_patron->move_to_deleted ), 'Koha::Schema::Result::Deletedborrower', 'Koha::Patron->move_to_deleted should return the Deleted patron' ) > ; # FIXME This should be Koha::Deleted::Patron > my $deleted_patron = $schema->resultset('Deletedborrower') > ->search( { borrowernumber => $patron->{borrowernumber} }, { result_class => 'DBIx::Class::ResultClass::HashRefInflator' } ) > ->next; >+ isnt( $deleted_patron->{updated_on}, $retrieved_patron->{updated_on}, 'Koha::Patron->move_to_deleted should have correctly updated the updated_on column'); >+ $deleted_patron->{updated_on} = $originally_updated_on; #reset for simplicity in comparing all other fields > is_deeply( $deleted_patron, $patron, 'Koha::Patron->move_to_deleted should have correctly moved the patron to the deleted table' ); > $retrieved_patron->delete( $patron->{borrowernumber} ); # Cleanup > }; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17782
:
58203
|
58890
|
58913
|
59558
|
59573
|
59583
|
59605
|
59606
|
59607
|
60047