Bugzilla – Attachment 59607 Details for
Bug 17782
Patron updated_on field should be set to current timestamp when borrower is deleted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17782: Fix tests
Bug-17782-Fix-tests.patch (text/plain), 2.01 KB, created by
Jonathan Druart
on 2017-01-27 09:15:50 UTC
(
hide
)
Description:
Bug 17782: Fix tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-01-27 09:15:50 UTC
Size:
2.01 KB
patch
obsolete
>From 3c23029309ac2ca2669c6e883fec54b6ff144ed0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 27 Jan 2017 10:14:46 +0100 >Subject: [PATCH] Bug 17782: Fix tests > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Koha/Patrons.t | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t >index f666507..0e6791a 100644 >--- a/t/db_dependent/Koha/Patrons.t >+++ b/t/db_dependent/Koha/Patrons.t >@@ -318,7 +318,7 @@ subtest 'renew_account' => sub { > }; > > subtest "move_to_deleted" => sub { >- plan tests => 3; >+ plan tests => 5; > my $originally_updated_on = '2016-01-01 12:12:12'; > my $patron = $builder->build( { source => 'Borrower',value => { updated_on => $originally_updated_on } } ); > my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} ); >@@ -327,7 +327,9 @@ subtest "move_to_deleted" => sub { > my $deleted_patron = $schema->resultset('Deletedborrower') > ->search( { borrowernumber => $patron->{borrowernumber} }, { result_class => 'DBIx::Class::ResultClass::HashRefInflator' } ) > ->next; >- isnt( $deleted_patron->{updated_on}, $retrieved_patron->{updated_on}, 'Koha::Patron->move_to_deleted should have correctly updated the updated_on column'); >+ ok( $retrieved_patron->updated_on, 'updated_on should be set for borrowers table' ); >+ ok( $deleted_patron->{updated_on}, 'updated_on should be set for deleted_borrowers table' ); >+ isnt( $deleted_patron->{updated_on}, $retrieved_patron->updated_on, 'Koha::Patron->move_to_deleted should have correctly updated the updated_on column'); > $deleted_patron->{updated_on} = $originally_updated_on; #reset for simplicity in comparing all other fields > is_deeply( $deleted_patron, $patron, 'Koha::Patron->move_to_deleted should have correctly moved the patron to the deleted table' ); > $retrieved_patron->delete( $patron->{borrowernumber} ); # Cleanup >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17782
:
58203
|
58890
|
58913
|
59558
|
59573
|
59583
|
59605
|
59606
| 59607 |
60047